Allow skipping of appenders when demoting log level via middleware #398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a middleware demotes a log's `:level` below an appender's `:min-level`, that appender will now be skipped. This behavior is consistent with e.g. `:msg_` which was already exposed to the changed log level.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a middleware demotes a log's
:levelbelow an appender's:min-level, that appender will now be skipped. This behavior is consistent with e.g.:msg_which was already exposed to the changed log level.Review notes
:hash_. I'm not 100% sure whether this makes sense.levelstest is the best place for the assertion but it seemed like a good fit to me.