-
-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Jetty9 server adapter to ring-jetty9-adapter's new websocket fix #408
Conversation
Currently, I can't find a way to response a {:body sch} inside ring-req->server-ch-resp.
Update jetty9.clj
@surferHalo Hi Jian, thank you for your PR - and sorry for the long delay replying on this! In your PR, you have the following code: (defn- server-ch-resp
[websocket? {:keys [on-open on-close on-msg on-error]}]
(jetty/ws-upgrade-response
{:on-connect (fn [sch] (on-open sch websocket?))
:on-text (fn [sch msg] (on-msg sch websocket? msg))
:on-error (fn [sch error] (on-error sch websocket? error))
:on-close (fn [sch status _] (on-close sch websocket? status))})) I'm not familiar with this Jetty9 adapter, but it looks strange to me that the Is this really correct? Ajax will work correctly even when Also, you mention in your commit message:
I don't understand. Can you explain a bit more why you wrote this? Thanks! |
Closing to consolidate efforts at #424 |
Currently, ring-Jetty9-adapter does not regard websocket as a separate ring handler.
sunng87/ring-jetty9-adapter#59