Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Rust edition 2024 #756

Closed
wants to merge 1 commit into from

Conversation

jeff-hiner
Copy link

Currently supported as of Rust stable 1.85.0, so we should also make sure setting edition = "2024" doesn't throw errors.

@panekj
Copy link
Collaborator

panekj commented Mar 6, 2025

Duplicate of #751

@panekj panekj marked this as a duplicate of #751 Mar 6, 2025
@panekj panekj closed this Mar 6, 2025
@jeff-hiner
Copy link
Author

jeff-hiner commented Mar 6, 2025

@panekj Was there a reason #751 was closed without merging? This issue is currently causing the plugin to fail currently on any 2024 edition Cargo.toml. Is the pull from schemastore just not yet released?

@panekj
Copy link
Collaborator

panekj commented Mar 6, 2025

Was there a reason #751 was closed without merging?

The reason is stated in the PR.

Is the pull from schemastore just not yet released?

It has been available since March 29, 2024
SchemaStore/schemastore@6e4146f

@jeff-hiner
Copy link
Author

Okay. So do I have to do something special within vscode to get my valid Cargo.toml to not throw errors?

@panekj
Copy link
Collaborator

panekj commented Mar 6, 2025

Check what schema is used when you have the file open and try switching it manually as well
image

@panekj
Copy link
Collaborator

panekj commented Mar 6, 2025

It should be Cargo Manifest

@jeff-hiner
Copy link
Author

It was already Cargo Manifest, but for some reason it was using an outdated version of the cargo.json from upstream. Deleting the ~/.config/Code/User/globalStorage/tamasfe.even-better-toml/ contents and restarting vscode fixed it, but there's probably some sort of caching bug still.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants