Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shopify VCS warning #343

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Shopify VCS warning #343

wants to merge 2 commits into from

Conversation

Doimhneacht
Copy link
Contributor

@Doimhneacht Doimhneacht commented Nov 1, 2024

Copy link

There was error processing your body

The exact error message is the following

Error: You must pass a string or Handlebars AST to Handlebars.compile. You passed null

at Object.compile (/var/task/node_modules/handlebars/dist/cjs/handlebars/compiler/compiler.js:501:11)
at HandlebarsEnvironment.hb.compile (/var/task/node_modules/handlebars/dist/cjs/handlebars.js:39:40)
at new HandlebarCompiler (/var/task/lib/HandlebarCompiler.js:6:38)
at PayloadHelper.getNewBody (/var/task/lib/PayloadHelper.js:41:24)
at App. (/var/task/lib/App.js:65:54)
at step (/var/task/lib/App.js:32:23)
at Object.next (/var/task/lib/App.js:13:53)
at /var/task/lib/App.js:7:71
at new Promise ()
at __awaiter (/var/task/lib/App.js:3:12)
at App.handleEvent (/var/task/lib/App.js:59:16)
at App.handleEvent (/var/task/lib/App.js:52:20)
at Application. (/var/task/node_modules/probot/lib/application.js:153:50)
at step (/var/task/node_modules/probot/lib/application.js:43:23)
at Object.next (/var/task/node_modules/probot/lib/application.js:24:53)
at fulfilled (/var/task/node_modules/probot/lib/application.js:15:58)
at process._tickCallback (internal/process/next_tick.js:68:7)

This body won't be processed any further, please fix your template.

@@ -36,6 +36,13 @@ Automatic integration
To check how Standalone Campaign looks visit */pages/share* or */pages/invite* links of your store.
You can edit these links in Administrative panel of your store.

.. important::

If you are managing the Shopify theme code using a version control system (e.g. git),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is a link with documentation for Shopify-GitHub integration, I think it will be useful to use it for the reference: https://shopify.dev/docs/storefronts/themes/tools/github.
Therefore I'd use Shopify GitHub integration for themes instead of abstract managing the Shopify theme code using a version control system to be consistent with Shopify terms

@dgtv dgtv added the WIP Work in progress label Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP Work in progress
Development

Successfully merging this pull request may close these issues.

2 participants