[PR-22076] [Placements] Update integration lib to specify div #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhuravel
approved these changes
Jun 13, 2024
Co-authored-by: Bohdan Zhuravel <[email protected]>
max-si-m
approved these changes
Jun 20, 2024
dgtv
reviewed
Jun 20, 2024
| @@ -35,6 +38,8 @@ Shopify Platform | |||
| #. **Configure Campaign and Placement.** Create a new Campaign with Post Purchase type of Placement, | |||
| configure it and launch. It will be automatically attached to the Post Purchase Placement and so, | |||
| show up to your customers every time they purchase successfully on your site. | |||
| |br| | |||
| In the placement settings, you can now change the `div` id value. It can be customized to any value you type. | |||
There was a problem hiding this comment.
@bohdan-perekhrest Should customer update something on a page or integration when updating div value for placement or it will be automatically dynamically created with the proper id?
There was a problem hiding this comment.
no, customer must go and change div on his page to the same as placement container name value.
dgtv
reviewed
Jul 1, 2024
| @@ -51,6 +56,8 @@ Magento Platform | |||
| #. **Configure Campaign and Placement.** Create a new Campaign with Post Purchase type of Placement, | |||
| configure it and launch. It will be automatically attached to the Post Purchase Placement and so, | |||
| show up to your customers every time they purchase successfully on your site. | |||
| |br| | |||
| In the placement settings, you can now change the `div` id value. It can be customized to any value you type. | |||
There was a problem hiding this comment.
As this change can easily break the integration + it requires div to be updated in sync on site after changes in Admin panel I think we should make editing of Talkable Container DIV Staff only feature that will be used by PS team only. Because of this we shouldn't document DIV editing in this documentation but just actualise div values we communicate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backend part: talkable/talkable#9777
Integration part: talkable/talkable-integration#743
Related Stories