Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR-22094] Fix docs.talkable.com SEO critical issues #328

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

ilovepinkpony1
Copy link
Contributor

@ilovepinkpony1 ilovepinkpony1 commented Jun 5, 2024

source/_templates/layout.html Outdated Show resolved Hide resolved
@@ -183,7 +183,7 @@

# The URL which points to the root of the HTML documentation.
# It is used to indicate the location of document like canonical_url.
html_baseurl = 'https://docs.talkable.com'
# html_baseurl = 'https://docs.talkable.com'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this commented out?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zhuravel html_baseurl added a link attribute to the main page with canonnical link 'https://docs.talkable.com/index.html', what we want actually is 'https://docs.talkable.com', to achieve this, we moved this logic to linktags.html

@zhuravel zhuravel self-assigned this Jun 5, 2024
@zhuravel zhuravel added the LG Looks good label Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LG Looks good
Development

Successfully merging this pull request may close these issues.

2 participants