Merge pull request #7 from taketo1113/http1.1-default-port

Fix default port 443 with doh http/1.1
taketo1113 · May 15, 2024 · cb5f303 · cb5f303
2 parents 3ffd813 + ac8d6f4
commit cb5f303
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/lib/ddig/ddr/designated_resolver.rb b/lib/ddig/ddr/designated_resolver.rb
@@ -77,9 +77,7 @@ def to_s
       # ref: https://www.rfc-editor.org/rfc/rfc9461.html#section-4.2
       def set_default_port
         case @protocol
-        when 'http/1.1'
-          @port = 80
-        when 'h2', 'h3'
+        when 'http/1.1', 'h2', 'h3'
           @port = 443
         when 'dot', 'doq'
           @port = 853

diff --git a/spec/ddig/ddr/designated_resolver_spec.rb b/spec/ddig/ddr/designated_resolver_spec.rb
@@ -6,7 +6,7 @@
       it "return default port with protocol: http/1.1" do
         @designated_resolver = Ddig::Ddr::DesignatedResolver.new(unencrypted_resolver: '8.8.8.8', target: 'dns.google', protocol: 'http/1.1', port: nil, dohpath: nil, address: '8.8.4.4', ip: :ipv4)
 
-        expect(@designated_resolver.port).to eq 80
+        expect(@designated_resolver.port).to eq 443
       end
 
       it "return default port with protocol: h2" do