server: add a RoutePrefix option #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases it is useful to run TailSQL on a server that already has other endpoints. To support this, add a RoutePrefix option: When this is set, it will be prepended to the the UI, API, and static file routes handled by the tailsql server. - Add tests to exercise prefixed routes. - Plumb the prefix into the UI template and use it for static files. - Fix an absolute path in the style sheet. - Fix an absolute path in the CSV download script. - Log a prefixed route in the example CLI.
creachadair
commented
Jul 16, 2024
| @@ -186,7 +186,7 @@ div.action { | |||
| .action .ctrl:before { | |||
| display: none; | |||
| } | |||
| .action .ctrl:-webkit-details-marker { | |||
| .action .ctrl::-webkit-details-marker { | |||
There was a problem hiding this comment.
This is an unrelated syntax issue I just happened to notice while testing.
maisem
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases it is useful to run TailSQL on a server that already has other
endpoints. To support this, add a RoutePrefix option: When this is set, it will
be prepended to the the UI, API, and static file routes handled by the tailsql
server.