server/tailsql: an indirect note about pronunciation #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
creachadair
force-pushed
the
mjf/squirrel
branch
from
55203ec
to
c644e2f
Compare
phirework
reviewed
Sep 20, 2023
Comment on lines
+29
to
+32
| function maybeRunSquirrel() { | ||
| if (!shouldSquirrel()) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
this sequence of function names is SO funny 😂
phirework
reviewed
Sep 20, 2023
| // Squirrel art from: | ||
| // http://saralara93.blogspot.com/2014/03/concept-art-part-3-squirrel.html | ||
|
|
||
| const nut = document.createElement("div"); |
There was a problem hiding this comment.
You could put this element in the HTML instead and just have it always be there but invisible, so that the whole interface doesn't shift when the squirrel appears.
There was a problem hiding this comment.
Hmm, I had originally added it there with display:none, but it still moves the item above. Probably I should move the "version" stamp inside the container so the squirrel runs over top of it instead of hoisting it.
There was a problem hiding this comment.
display: none collapses the element even if you have a height/width set, you want visibility: hidden
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.