Skip to content

cgosqlite: use conventional comment style for C preambles #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 28, 2025
Merged

cgosqlite: use conventional comment style for C preambles #114

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
80 changes: 41 additions & 39 deletions cgosqlite/cgosqlite.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,51 +1,53 @@
package cgosqlite

/*
// This list of compiler options is heavily influenced by:
//
// https://www.sqlite.org/compile.html#recommended_compile_time_options
//
// One exception is we do not use SQLITE_OMIT_DECLTYPE, as the design
// of the database/sql driver seems to require it.

// #cgo CFLAGS: -DSQLITE_THREADSAFE=2
// #cgo CFLAGS: -DSQLITE_DQS=0
// #cgo CFLAGS: -DSQLITE_DEFAULT_MEMSTATUS=0
// #cgo CFLAGS: -DSQLITE_DEFAULT_WAL_SYNCHRONOUS=1
// #cgo CFLAGS: -DSQLITE_LIKE_DOESNT_MATCH_BLOBS
// #cgo CFLAGS: -DSQLITE_MAX_EXPR_DEPTH=0
// #cgo CFLAGS: -DSQLITE_OMIT_DEPRECATED
// #cgo CFLAGS: -DSQLITE_OMIT_PROGRESS_CALLBACK
// #cgo CFLAGS: -DSQLITE_OMIT_SHARED_CACHE
// #cgo CFLAGS: -DSQLITE_USE_ALLOCA
// #cgo CFLAGS: -DSQLITE_OMIT_AUTOINIT
// #cgo CFLAGS: -DSQLITE_OMIT_LOAD_EXTENSION
// #cgo CFLAGS: -DSQLITE_ENABLE_FTS5
// #cgo CFLAGS: -DSQLITE_ENABLE_RTREE
// #cgo CFLAGS: -DSQLITE_ENABLE_JSON1
// #cgo CFLAGS: -DSQLITE_ENABLE_SESSION
// #cgo CFLAGS: -DSQLITE_ENABLE_SNAPSHOT
// #cgo CFLAGS: -DSQLITE_ENABLE_PREUPDATE_HOOK
// #cgo CFLAGS: -DSQLITE_ENABLE_COLUMN_METADATA
// #cgo CFLAGS: -DSQLITE_ENABLE_STAT4
// #cgo CFLAGS: -DSQLITE_ENABLE_DBSTAT_VTAB=1
// #cgo CFLAGS: -DSQLITE_TEMP_STORE=1
// #cgo CFLAGS: -DHAVE_USLEEP=1
//
// // Select POSIX 2014 at least for clock_gettime.
// #cgo CFLAGS: -D_XOPEN_SOURCE=600
// #cgo CFLAGS: -D_DARWIN_C_SOURCE=1
//
// // Ignore unknown warning options, to silence spurious complaints from
// // Apple's build of Clang that does not know certain GCC warnings.
// #cgo CFLAGS: -Wno-unknown-warning-option
//
// // Quiet bogus warnings (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115274)
// #cgo CFLAGS: -Wno-stringop-overread
//
// // libm is required by the FTS5 extension, on Linux.
// #cgo linux LDFLAGS: -lm
//
// #include "cgosqlite.h"
#cgo CFLAGS: -DSQLITE_THREADSAFE=2
#cgo CFLAGS: -DSQLITE_DQS=0
#cgo CFLAGS: -DSQLITE_DEFAULT_MEMSTATUS=0
#cgo CFLAGS: -DSQLITE_DEFAULT_WAL_SYNCHRONOUS=1
#cgo CFLAGS: -DSQLITE_LIKE_DOESNT_MATCH_BLOBS
#cgo CFLAGS: -DSQLITE_MAX_EXPR_DEPTH=0
#cgo CFLAGS: -DSQLITE_OMIT_DEPRECATED
#cgo CFLAGS: -DSQLITE_OMIT_PROGRESS_CALLBACK
#cgo CFLAGS: -DSQLITE_OMIT_SHARED_CACHE
#cgo CFLAGS: -DSQLITE_USE_ALLOCA
#cgo CFLAGS: -DSQLITE_OMIT_AUTOINIT
#cgo CFLAGS: -DSQLITE_OMIT_LOAD_EXTENSION
#cgo CFLAGS: -DSQLITE_ENABLE_FTS5
#cgo CFLAGS: -DSQLITE_ENABLE_RTREE
#cgo CFLAGS: -DSQLITE_ENABLE_JSON1
#cgo CFLAGS: -DSQLITE_ENABLE_SESSION
#cgo CFLAGS: -DSQLITE_ENABLE_SNAPSHOT
#cgo CFLAGS: -DSQLITE_ENABLE_PREUPDATE_HOOK
#cgo CFLAGS: -DSQLITE_ENABLE_COLUMN_METADATA
#cgo CFLAGS: -DSQLITE_ENABLE_STAT4
#cgo CFLAGS: -DSQLITE_ENABLE_DBSTAT_VTAB=1
#cgo CFLAGS: -DSQLITE_TEMP_STORE=1
#cgo CFLAGS: -DHAVE_USLEEP=1

// Select POSIX 2014 at least for clock_gettime.
#cgo CFLAGS: -D_XOPEN_SOURCE=600
#cgo CFLAGS: -D_DARWIN_C_SOURCE=1

// Ignore unknown warning options, to silence spurious complaints from
// Apple's build of Clang that does not know certain GCC warnings.
#cgo CFLAGS: -Wno-unknown-warning-option

// Quiet bogus warnings (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115274)
#cgo CFLAGS: -Wno-stringop-overread

// libm is required by the FTS5 extension, on Linux.
#cgo linux LDFLAGS: -lm

#include "cgosqlite.h"
*/
import "C"
import (
"sync"
Expand Down
28 changes: 15 additions & 13 deletions cgosqlite/logcallback.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,20 @@
package cgosqlite

// #include <sqlite3.h>
//
// void logCallbackGo(void* userData, int errCode, char* msgC);
//
// static void log_callback_into_go(void *userData, int errCode, const char *msg) {
// logCallbackGo(userData, errCode, (char*)msg);
// }
//
// static int ts_sqlite3_config_log(void) {
// // TODO(raggi): if the library gains new uses of sqlite3_config they need to
// // share a mutex.
// return sqlite3_config(SQLITE_CONFIG_LOG, log_callback_into_go, NULL);
// }
/*
#include <sqlite3.h>

void logCallbackGo(void* userData, int errCode, char* msgC);

static void log_callback_into_go(void *userData, int errCode, const char *msg) {
logCallbackGo(userData, errCode, (char*)msg);
}

static int ts_sqlite3_config_log(void) {
// TODO(raggi): if the library gains new uses of sqlite3_config they need to
// share a mutex.
return sqlite3_config(SQLITE_CONFIG_LOG, log_callback_into_go, NULL);
}
*/
import "C"
import (
"sync"
Expand Down
4 changes: 3 additions & 1 deletion cgosqlite/walcallback.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
package cgosqlite

// #include <sqlite3.h>
/*
#include <sqlite3.h>
*/
import "C"
import (
"sync"
Expand Down
Loading