MacOS: Build open source tailscale binaries #142
+31
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gurchik
commented
Oct 28, 2024
| if: ${{ runner.os == 'macOS' }} | ||
| shell: bash | ||
| run: | ||
| networksetup -setdnsservers "Ethernet" 100.100.100.100 |
There was a problem hiding this comment.
This may cause problems for users that are running a non-ephemeral (self-hosted) Mac runner after the build is over, as the DNS server of the machine will still remain set to Quad 100. Ideally the Action is using a post cleanup step to set the DNS server back. I suspect this Action already has other problems for non-ephemeral Linux runners as well. Therefore, I think adding appropriate post cleanup steps would be a future improvement. This DNS setting poses no problem for ephemeral runners.
This was referenced Oct 28, 2024
|
Ping @willnorris |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add MacOS support by building the open source tailscale binaries.
This is similar to #103 except it builds the Go project manually from the instructions on Github.
Of course, this requires us to first install Go, which is regrettable as it may break some people's workflow, but I don't see any other way until Tailscale provides these binaries themselves. Setting up Go and building the binaries takes about 30 seconds, which isn't great but not terrible.
I am currently using this on
macos-latestand it is working as expected, but it may be possible that the DNS configuration does not work for some versions of MacOS. If desired, you can add more versions of MacOS to test.