Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: fix thread contention problem #3085

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Conversation

laststylebender14
Copy link
Contributor

Summary:
Briefly describe the changes made in this PR.

Issue Reference(s):
Fixes #... (Replace "..." with the issue number)

Build & Testing:

  • I ran cargo test successfully.
  • I have run ./lint.sh --mode=fix to fix all linting issues raised by ./lint.sh --mode=check.

Checklist:

  • I have added relevant unit & integration tests.
  • I have updated the documentation accordingly.
  • I have performed a self-review of my code.
  • PR follows the naming convention of <type>(<optional scope>): <title>

@laststylebender14 laststylebender14 marked this pull request as draft October 29, 2024 12:19
@github-actions github-actions bot added ci: benchmark Runs benchmarks type: fix Iterations on existing features or infrastructure. type: performance Improved performance. labels Oct 29, 2024
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 75.71429% with 17 lines in your changes missing coverage. Please review.

Project coverage is 87.22%. Comparing base (2c67ac5) to head (571ae20).

Files with missing lines Patch % Lines
src/core/http/request_handler.rs 75.67% 9 Missing ⚠️
src/core/async_graphql_hyper.rs 20.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3085      +/-   ##
==========================================
- Coverage   87.22%   87.22%   -0.01%     
==========================================
  Files         280      280              
  Lines       27425    27436      +11     
==========================================
+ Hits        23921    23930       +9     
- Misses       3504     3506       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

🐰 Bencher Report

Branch3085/merge
Testbedbenchmarking-runner

⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencynanoseconds (ns)
from_json_bench📈 view plot
⚠️ NO THRESHOLD
6,238,000.00
group_by📈 view plot
⚠️ NO THRESHOLD
503.15
input/args.missing📈 view plot
⚠️ NO THRESHOLD
22.70
input/args.nested.existing📈 view plot
⚠️ NO THRESHOLD
44.02
input/args.nested.missing📈 view plot
⚠️ NO THRESHOLD
38.13
input/args.root📈 view plot
⚠️ NO THRESHOLD
39.41
input/headers.existing📈 view plot
⚠️ NO THRESHOLD
32.65
input/headers.missing📈 view plot
⚠️ NO THRESHOLD
31.53
input/value.missing📈 view plot
⚠️ NO THRESHOLD
23.34
input/value.nested.existing📈 view plot
⚠️ NO THRESHOLD
43.84
input/value.nested.missing📈 view plot
⚠️ NO THRESHOLD
37.28
input/value.root📈 view plot
⚠️ NO THRESHOLD
38.39
input/vars.existing📈 view plot
⚠️ NO THRESHOLD
8.96
input/vars.missing📈 view plot
⚠️ NO THRESHOLD
8.37
synth_nested📈 view plot
⚠️ NO THRESHOLD
93,714.00
synth_nested_borrow📈 view plot
⚠️ NO THRESHOLD
42,419.00
test_batched_body📈 view plot
⚠️ NO THRESHOLD
1,903.00
test_batched_body #2📈 view plot
⚠️ NO THRESHOLD
1,556,400.00
test_data_loader📈 view plot
⚠️ NO THRESHOLD
394,890.00
test_handle_request📈 view plot
⚠️ NO THRESHOLD
130,360.00
test_handle_request_jit📈 view plot
⚠️ NO THRESHOLD
63,834.00
test_http_execute_method📈 view plot
⚠️ NO THRESHOLD
15,030.00
with_mustache_expressions📈 view plot
⚠️ NO THRESHOLD
1,105.80
with_mustache_literal📈 view plot
⚠️ NO THRESHOLD
684.55
🐰 View full continuous benchmarking report in Bencher

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci: benchmark Runs benchmarks type: fix Iterations on existing features or infrastructure. type: performance Improved performance.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant