Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(2775): send metrics to posthog #2776

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

beelchester
Copy link
Contributor

@beelchester beelchester commented Sep 1, 2024

fixes: #2775
/claim #2775

Screenshot 2024-09-01 at 5 44 44 PM

Steps to test:

  1. Add posthog project api key to env POSTHOG_API_SECRET.
  2. For local testing I had to hardcode is_tracking to true.
  3. Run cargo test on tailcall-tracker or just use build the project and run any argument.
  4. Check the activity section in posthog project events should appear.

@beelchester beelchester marked this pull request as draft September 1, 2024 09:06
@algora-pbc algora-pbc bot mentioned this pull request Sep 1, 2024
@github-actions github-actions bot added the type: chore Routine tasks like conversions, reorganization, and maintenance work. label Sep 1, 2024
Copy link

codecov bot commented Sep 1, 2024

Codecov Report

Attention: Patch coverage is 19.63190% with 131 lines in your changes missing coverage. Please review.

Project coverage is 86.95%. Comparing base (d02b6e6) to head (84af049).

Files with missing lines Patch % Lines
tailcall-tracker/src/collect/collectors.rs 13.20% 46 Missing ⚠️
tailcall-tracker/src/collect/posthog.rs 9.09% 30 Missing ⚠️
tailcall-tracker/src/collect/ga.rs 20.58% 27 Missing ⚠️
tailcall-tracker/src/tracker.rs 57.69% 11 Missing ⚠️
src/cli/command.rs 0.00% 7 Missing ⚠️
src/cli/tc/run.rs 0.00% 4 Missing ⚠️
tailcall-tracker/src/collect/ga_event.rs 0.00% 4 Missing ⚠️
tailcall-tracker/src/error.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2776      +/-   ##
==========================================
- Coverage   87.13%   86.95%   -0.18%     
==========================================
  Files         254      257       +3     
  Lines       25144    25250     +106     
==========================================
+ Hits        21910    21957      +47     
- Misses       3234     3293      +59     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@beelchester beelchester marked this pull request as ready for review September 1, 2024 11:14
Signed-off-by: Sahil Yeole <[email protected]>
Signed-off-by: Sahil Yeole <[email protected]>
@tusharmath tusharmath marked this pull request as draft September 1, 2024 12:54
@tusharmath
Copy link
Contributor

  • Added comments
  • CI is failing which needs fixing
  • Add steps to test the feature

Moving to draft to reduce noise and improve CI efficiency. Once you are ready just mark it as "ready to review". Feel free to give a shoutout on the #contributors channel on Discord if you want immediate attention.

@tusharmath tusharmath added type: feature Brand new functionality, features, pages, workflows, endpoints, etc. and removed type: chore Routine tasks like conversions, reorganization, and maintenance work. labels Sep 1, 2024
@tusharmath tusharmath changed the title chore(2775): send metrics to posthog feat(2775): send metrics to posthog Sep 1, 2024
beelchester and others added 5 commits September 1, 2024 21:00
@beelchester beelchester marked this pull request as ready for review September 2, 2024 02:00
Copy link

github-actions bot commented Sep 7, 2024

Action required: PR inactive for 5 days.
Status update or closure in 10 days.

@github-actions github-actions bot added the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Sep 7, 2024
@github-actions github-actions bot removed the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Sep 8, 2024
@tusharmath tusharmath changed the title feat(2775): send metrics to posthog fix(2775): send metrics to posthog Sep 10, 2024
@github-actions github-actions bot added the type: fix Iterations on existing features or infrastructure. label Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🙋 Bounty claim type: feature Brand new functionality, features, pages, workflows, endpoints, etc. type: fix Iterations on existing features or infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Push data to PostHog
2 participants