fix(2694): tailcall server run via npx command #2733

webbdays · 2024-08-18T01:54:19Z

Summary:
fix the problem with package executable path

Issue Reference(s):
Fixes #2694

Build & Testing:

I ran cargo test successfully.
I have run ./lint.sh --mode=fix to fix all linting issues raised by ./lint.sh --mode=check.

Checklist:

I have added relevant unit & integration tests.
I have updated the documentation accordingly.
[ yes] I have performed a self-review of my code.
[ yes] PR follows the naming convention of <type>(<optional scope>): <title>

webbdays · 2024-08-18T02:06:15Z

@tusharmath
Please review.

webbdays · 2024-08-24T06:20:46Z

make sure build-matrix is latest when merged.

.github/workflows/build_matrix.yml

npm/pre-install.js

tusharmath

@webbdays, can you describe how this PR will fix the above issue? There are quite a few changes that don't seem relevant in the first glance. Is there a way you can create a smaller PR with just the requried changes.

webbdays · 2024-08-27T02:45:34Z

@tusharmath
root cause: cannot find a executable.
reason: we are installing another package within a package.
so the package name is different.
binary for tailcall is in platform specific package bin/ folder.
where as when using with npx, it is trying to find the executable in tailcall/bin/ which we dont have.
so error.

So, what i am doing is instead of installing package within a package, we install only one package and we get the platform specific binary from the github releases and place it in tailcall/bin/
here after any tools can find it.
be it npx, npm.

github-actions · 2024-09-01T04:04:08Z

Action required: PR inactive for 5 days.
Status update or closure in 10 days.

codecov · 2024-09-06T01:18:38Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.84%. Comparing base (dbf10b4) to head (47f2c79).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2733   +/-   ##
=======================================
  Coverage   87.84%   87.84%           
=======================================
  Files         263      263           
  Lines       26252    26252           
=======================================
  Hits        23061    23061           
  Misses       3191     3191

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

.github/build-matrix.yaml

tusharmath · 2024-09-07T04:09:29Z

Overall the PR looks fine to me. CI is failing. Can you check and debug this issue? Moving to draft to reduce noise and improve CI efficiency. Once you are ready just mark it as "ready to review". Feel free to give a shoutout on the #contributors channel on Discord if you want immediate attention.

webbdays · 2024-09-08T08:34:41Z

ok. checking the issue.

webbdays · 2024-09-08T08:42:46Z

ci is failing on code in main.
this pr didnt touch rust.

webbdays · 2024-09-10T17:19:48Z

@tusharmath
ready for review.

github-actions · 2024-09-17T14:02:46Z

Action required: PR inactive for 5 days.
Status update or closure in 10 days.

github-actions · 2024-09-22T16:02:52Z

Action required: PR inactive for 5 days.
Status update or closure in 10 days.

amitksingh1490 · 2024-09-25T11:52:27Z

npm/post-install.js

+
+let libc = ""
+if (os === "win32") {
+  libc = "msvc"


why have we dropped the - here

currently implementation doest need it.

amitksingh1490 · 2024-09-25T11:52:51Z

npm/pre-install.js

+const libcFamily = familySync()
+
+let libc = ""
+if (os === "win32") {
+  libc = "msvc"
+} else {
+  libc = libcFamily === GLIBC ? "gnu" : libcFamily === MUSL ? "musl" : ""
+}


duplicate code

yes.
we can make a function inside utils.

This reverts commit 04e7a6a.

github-actions bot added the type: fix Iterations on existing features or infrastructure. label Aug 18, 2024

webbdays force-pushed the main branch from f323ad5 to 42df186 Compare August 18, 2024 01:56

tusharmath changed the title ~~fix: tailcall server run via npx command (npx @tailcallhq/tailcall) #2694~~ fix(2694): tailcall server run via npx command Aug 26, 2024

tusharmath reviewed Aug 26, 2024

View reviewed changes

.github/workflows/build_matrix.yml Outdated Show resolved Hide resolved

tusharmath reviewed Aug 26, 2024

View reviewed changes

npm/pre-install.js Show resolved Hide resolved

tusharmath requested changes Aug 26, 2024

View reviewed changes

webbdays force-pushed the main branch from 46e340f to be6bdac Compare August 27, 2024 02:44

webbdays force-pushed the main branch from 3def97e to 26d3124 Compare August 27, 2024 03:01

fix npx run

8e471e5

webbdays force-pushed the main branch from 26d3124 to 8e471e5 Compare August 27, 2024 03:17

github-actions bot added the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Sep 1, 2024

Merge branch 'main' into main

2f6e8c8

github-actions bot removed the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Sep 1, 2024

Brihadeeshrk mentioned this pull request Sep 1, 2024

bug: the npx command doesn't work #2694

Open

webbdays added 2 commits September 1, 2024 22:50

Merge branch 'main' into main

af9bc1b

Merge branch 'main' into main

7cd9f1c

tusharmath reviewed Sep 7, 2024

View reviewed changes

.github/build-matrix.yaml Outdated Show resolved Hide resolved

tusharmath marked this pull request as draft September 7, 2024 04:09

webbdays added 2 commits September 10, 2024 18:57

Merge branch 'main' into main

b4c7665

fix

48a0829

webbdays force-pushed the main branch from 6764547 to 48a0829 Compare September 10, 2024 17:17

Merge branch 'main' into main

efbd790

webbdays marked this pull request as ready for review September 10, 2024 17:19

webbdays added 2 commits September 10, 2024 23:03

remove

3ac63ba

Merge branch 'main' into main

2ffc57d

github-actions bot added state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. and removed state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. labels Sep 17, 2024

github-actions bot added the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Sep 22, 2024

Merge branch 'main' into main

47f2c79

tusharmath approved these changes Sep 25, 2024

View reviewed changes

tusharmath enabled auto-merge (squash) September 25, 2024 11:51

tusharmath merged commit 04e7a6a into tailcallhq:main Sep 25, 2024
33 checks passed

amitksingh1490 reviewed Sep 25, 2024

View reviewed changes

tusharmath added a commit that referenced this pull request Sep 28, 2024

Revert "fix(2694): tailcall server run via npx command (#2733)"

46cbba6

This reverts commit 04e7a6a.

tusharmath mentioned this pull request Sep 28, 2024

fix: NPX release issue #2932

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(2694): tailcall server run via npx command #2733

fix(2694): tailcall server run via npx command #2733

webbdays commented Aug 18, 2024

webbdays commented Aug 18, 2024

webbdays commented Aug 24, 2024

tusharmath left a comment

webbdays commented Aug 27, 2024

github-actions bot commented Sep 1, 2024

codecov bot commented Sep 6, 2024 •

edited

Loading

tusharmath commented Sep 7, 2024

webbdays commented Sep 8, 2024

webbdays commented Sep 8, 2024

webbdays commented Sep 10, 2024 •

edited

Loading

github-actions bot commented Sep 17, 2024

github-actions bot commented Sep 22, 2024

amitksingh1490 Sep 25, 2024

webbdays Sep 26, 2024

amitksingh1490 Sep 25, 2024

webbdays Sep 26, 2024

fix(2694): tailcall server run via npx command #2733

fix(2694): tailcall server run via npx command #2733

Conversation

webbdays commented Aug 18, 2024

webbdays commented Aug 18, 2024

webbdays commented Aug 24, 2024

tusharmath left a comment

Choose a reason for hiding this comment

webbdays commented Aug 27, 2024

github-actions bot commented Sep 1, 2024

codecov bot commented Sep 6, 2024 • edited Loading

Codecov Report

tusharmath commented Sep 7, 2024

webbdays commented Sep 8, 2024

webbdays commented Sep 8, 2024

webbdays commented Sep 10, 2024 • edited Loading

github-actions bot commented Sep 17, 2024

github-actions bot commented Sep 22, 2024

amitksingh1490 Sep 25, 2024

Choose a reason for hiding this comment

webbdays Sep 26, 2024

Choose a reason for hiding this comment

amitksingh1490 Sep 25, 2024

Choose a reason for hiding this comment

webbdays Sep 26, 2024

Choose a reason for hiding this comment

codecov bot commented Sep 6, 2024 •

edited

Loading

webbdays commented Sep 10, 2024 •

edited

Loading