-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(jit): add field aliases and args support #2709
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2709 +/- ##
=======================================
Coverage 86.46% 86.46%
=======================================
Files 255 255
Lines 24963 24972 +9
=======================================
+ Hits 21584 21593 +9
Misses 3379 3379 ☔ View full report in Codecov by Sentry. |
Action required: PR inactive for 5 days. |
src/core/jit/snapshots/tailcall__core__jit__builder__tests__variables.snap
Outdated
Show resolved
Hide resolved
be39071
to
9469e66
Compare
@meskill, we can merge this. It fixes all JIT conformance test problems except introspection |
I've updated the pr with additional fixes and code cleanup. Please, check those and merge the pr if it's ok. Most of the snapshots changes are related to args ordering fix or new field |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's okay. The TODOs can be addressed later
Summary:
Briefly describe the changes made in this PR.
Issue Reference(s):
Fixes #... (Replace "..." with the issue number)
Build & Testing:
cargo test
successfully../lint.sh --mode=fix
to fix all linting issues raised by./lint.sh --mode=check
.Checklist:
<type>(<optional scope>): <title>