Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jit): add field aliases and args support #2709

Merged
merged 18 commits into from
Aug 26, 2024

Conversation

laststylebender14
Copy link
Contributor

@laststylebender14 laststylebender14 commented Aug 15, 2024

Summary:
Briefly describe the changes made in this PR.

Issue Reference(s):
Fixes #... (Replace "..." with the issue number)

Build & Testing:

  • I ran cargo test successfully.
  • I have run ./lint.sh --mode=fix to fix all linting issues raised by ./lint.sh --mode=check.

Checklist:

  • I have added relevant unit & integration tests.
  • I have updated the documentation accordingly.
  • I have performed a self-review of my code.
  • PR follows the naming convention of <type>(<optional scope>): <title>

@laststylebender14 laststylebender14 marked this pull request as draft August 15, 2024 15:45
@github-actions github-actions bot added type: chore Routine tasks like conversions, reorganization, and maintenance work. type: fix Iterations on existing features or infrastructure. labels Aug 15, 2024
Copy link

codecov bot commented Aug 15, 2024

Codecov Report

Attention: Patch coverage is 88.52459% with 7 lines in your changes missing coverage. Please review.

Project coverage is 86.46%. Comparing base (d0f6a76) to head (c5adc30).
Report is 1 commits behind head on main.

Files Patch % Lines
src/core/jit/synth/synth.rs 28.57% 5 Missing ⚠️
src/core/jit/context.rs 90.47% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2709   +/-   ##
=======================================
  Coverage   86.46%   86.46%           
=======================================
  Files         255      255           
  Lines       24963    24972    +9     
=======================================
+ Hits        21584    21593    +9     
  Misses       3379     3379           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Action required: PR inactive for 5 days.
Status update or closure in 10 days.

@github-actions github-actions bot added state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. and removed state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. labels Aug 21, 2024
@karatakis karatakis mentioned this pull request Aug 22, 2024
11 tasks
@karatakis karatakis force-pushed the chore/fix-http-conformance-test branch 3 times, most recently from be39071 to 9469e66 Compare August 22, 2024 13:44
@karatakis
Copy link
Collaborator

@meskill, we can merge this. It fixes all JIT conformance test problems except introspection

@karatakis karatakis marked this pull request as ready for review August 23, 2024 13:10
@meskill meskill added the ci: test-jit Run all integration tests for the JIT optimized engine label Aug 23, 2024
@meskill
Copy link
Contributor

meskill commented Aug 23, 2024

@meskill, we can merge this. It fixes all JIT conformance test problems except introspection

I've updated the pr with additional fixes and code cleanup. Please, check those and merge the pr if it's ok. Most of the snapshots changes are related to args ordering fix or new field

@meskill meskill changed the title chore: fix http conformance tests fix(jit): add field aliases and args support Aug 24, 2024
Copy link
Collaborator

@karatakis karatakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's okay. The TODOs can be addressed later

@meskill meskill merged commit 9a50f13 into main Aug 26, 2024
34 of 35 checks passed
@meskill meskill deleted the chore/fix-http-conformance-test branch August 26, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci: test-jit Run all integration tests for the JIT optimized engine type: chore Routine tasks like conversions, reorganization, and maintenance work. type: fix Iterations on existing features or infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants