Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move cli error to core #2708

Merged
merged 8 commits into from
Aug 26, 2024
Merged

refactor: move cli error to core #2708

merged 8 commits into from
Aug 26, 2024

Conversation

mehulmathur16
Copy link
Collaborator

No description provided.

@mehulmathur16 mehulmathur16 self-assigned this Aug 15, 2024
@github-actions github-actions bot added the type: chore Routine tasks like conversions, reorganization, and maintenance work. label Aug 15, 2024
@mehulmathur16 mehulmathur16 marked this pull request as draft August 15, 2024 14:52
Copy link

codecov bot commented Aug 15, 2024

Codecov Report

Attention: Patch coverage is 61.72840% with 31 lines in your changes missing coverage. Please review.

Project coverage is 86.65%. Comparing base (f66fc89) to head (657b429).
Report is 1 commits behind head on main.

Files Patch % Lines
src/core/errata.rs 71.05% 11 Missing ⚠️
src/core/ir/error.rs 61.53% 10 Missing ⚠️
src/cli/telemetry.rs 0.00% 2 Missing ⚠️
src/core/ir/eval.rs 0.00% 2 Missing ⚠️
src/main.rs 0.00% 2 Missing ⚠️
src/cli/server/http_1.rs 50.00% 1 Missing ⚠️
src/cli/server/http_2.rs 0.00% 1 Missing ⚠️
src/cli/tc/check.rs 0.00% 1 Missing ⚠️
src/core/http/response.rs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2708      +/-   ##
==========================================
- Coverage   86.66%   86.65%   -0.02%     
==========================================
  Files         255      255              
  Lines       25002    25020      +18     
==========================================
+ Hits        21669    21682      +13     
- Misses       3333     3338       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mehulmathur16 mehulmathur16 marked this pull request as ready for review August 16, 2024 06:32
Copy link

Action required: PR inactive for 5 days.
Status update or closure in 10 days.

@github-actions github-actions bot added the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Aug 21, 2024
# Conflicts:
#	src/cli/telemetry.rs
@tusharmath
Copy link
Contributor

/tip $50

@tusharmath tusharmath enabled auto-merge (squash) August 26, 2024 17:52
Copy link

algora-pbc bot commented Aug 26, 2024

🎉🎈 @mehulmathur16 has been awarded $50! 🎈🎊

@github-actions github-actions bot removed the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Aug 26, 2024
@tusharmath tusharmath merged commit 452648e into main Aug 26, 2024
36 of 39 checks passed
@tusharmath tusharmath deleted the move-cli-err branch August 26, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💰 Rewarded type: chore Routine tasks like conversions, reorganization, and maintenance work.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants