Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(2688): --watch for changes #2707

Open
wants to merge 25 commits into
base: main
Choose a base branch
from

Conversation

beelchester
Copy link
Contributor

@beelchester beelchester commented Aug 15, 2024

fixes: #2688
/claim #2688

Example

tailcall_watch.mp4

@algora-pbc algora-pbc bot mentioned this pull request Aug 15, 2024
@github-actions github-actions bot added the type: feature Brand new functionality, features, pages, workflows, endpoints, etc. label Aug 15, 2024
@beelchester beelchester marked this pull request as draft August 15, 2024 10:02
Copy link

codecov bot commented Aug 15, 2024

Codecov Report

Attention: Patch coverage is 0.66225% with 150 lines in your changes missing coverage. Please review.

Project coverage is 86.66%. Comparing base (36aba8f) to head (efc9515).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
src/cli/tc/start.rs 0.00% 139 Missing ⚠️
src/cli/server/http_server.rs 0.00% 8 Missing ⚠️
src/cli/tc/run.rs 0.00% 2 Missing ⚠️
src/cli/command.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2707      +/-   ##
==========================================
- Coverage   87.14%   86.66%   -0.48%     
==========================================
  Files         254      254              
  Lines       25144    25281     +137     
==========================================
- Hits        21911    21910       -1     
- Misses       3233     3371     +138     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@beelchester beelchester force-pushed the feat/watch-path branch 2 times, most recently from 4db457c to 2c39fd7 Compare August 15, 2024 14:29
Signed-off-by: Sahil Yeole <[email protected]>
Signed-off-by: Sahil Yeole <[email protected]>
Copy link

Action required: PR inactive for 5 days.
Status update or closure in 10 days.

@github-actions github-actions bot added the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Aug 22, 2024
@beelchester beelchester marked this pull request as ready for review August 23, 2024 06:25
@github-actions github-actions bot removed the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Aug 23, 2024
@tusharmath
Copy link
Contributor

On restarts the server should only log the following:

[INFO] Reloaded configuration ./examples/jsonplacholder.graphql

@beelchester

Validation errors don't show up in the restarts

Write an invalid configuration and start the server, it doesn't show any error.

@tusharmath tusharmath marked this pull request as draft August 26, 2024 14:27
@beelchester beelchester marked this pull request as ready for review August 31, 2024 04:02
Copy link

github-actions bot commented Sep 6, 2024

Action required: PR inactive for 5 days.
Status update or closure in 10 days.

@github-actions github-actions bot added the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Sep 6, 2024
@github-actions github-actions bot removed the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Sep 8, 2024
Copy link

Action required: PR inactive for 5 days.
Status update or closure in 10 days.

@github-actions github-actions bot added the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🙋 Bounty claim state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. type: feature Brand new functionality, features, pages, workflows, endpoints, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a --watch feature
2 participants