Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(2671): Moved retry logic from infer_type_name to wizard #2672

Closed
wants to merge 6 commits into from
Closed

refactor(2671): Moved retry logic from infer_type_name to wizard #2672

wants to merge 6 commits into from

Conversation

harshtech123
Copy link

@harshtech123 harshtech123 commented Aug 12, 2024 •
edited
Loading

/claim #2671

Summary:
Briefly describe the changes made in this PR.

Issue Reference(s):
Fixes #2671

Build & Testing:

  • I ran cargo test successfully.
  • I have run ./lint.sh --mode=fix to fix all linting issues raised by ./lint.sh --mode=check.

Checklist:

  • I have added relevant unit & integration tests.
  • I have updated the documentation accordingly.
  • I have performed a self-review of my code.
  • PR follows the naming convention of <type>(<optional scope>): <title>

@algora-pbc algora-pbc bot mentioned this pull request Aug 12, 2024
Open
@github-actions github-actions bot added the type: feature Brand new functionality, features, pages, workflows, endpoints, etc. label Aug 12, 2024
@harshtech123 harshtech123 changed the title feat(2671): Moved retry logic from infer_type_name to wizard refactor(2671): Moved retry logic from infer_type_name to wizard Aug 13, 2024
@tusharmath
Copy link
Contributor

Unnecessary files have been deleted. Please revert.

@github-actions github-actions bot added the type: chore Routine tasks like conversions, reorganization, and maintenance work. label Aug 13, 2024
harshtech123
harshtech123 commented Aug 13, 2024
View reviewed changes
Copy link
Author

@harshtech123 harshtech123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done with updates

src/cli/llm/infer_type_name.rs Show resolved Hide resolved
harshtech123
harshtech123 commented Aug 13, 2024
View reviewed changes
Copy link
Author

@harshtech123 harshtech123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uodated @tusharmath

@tusharmath
Copy link
Contributor

closing in favour of #2673

@tusharmath tusharmath closed this Aug 13, 2024
@tusharmath
Copy link
Contributor

@harshtech123 I think you are going mostly in the right direction but end up pushing changes with unnecessary file updates. Please feel free to create a new PR that's cleaner.

@harshtech123
Copy link
Author

@tusharmath i have created a new pr , kindly check that one
#2680

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tusharmath tusharmath tusharmath left review comments

Assignees
No one assigned
Labels
🙋 Bounty claim type: chore Routine tasks like conversions, reorganization, and maintenance work. type: feature Brand new functionality, features, pages, workflows, endpoints, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor: Move retry logic from infer_type_name to wizard
2 participants
@harshtech123 @tusharmath