Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fmt to capture Writer #2644

Closed
wants to merge 4 commits into from
Closed

Conversation

ssddOnTop
Copy link
Member

related to #2640

@github-actions github-actions bot added the type: chore Routine tasks like conversions, reorganization, and maintenance work. label Aug 11, 2024
@ssddOnTop ssddOnTop marked this pull request as ready for review August 11, 2024 06:31
Copy link

codecov bot commented Aug 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 49 lines in your changes missing coverage. Please review.

Project coverage is 87.40%. Comparing base (e10eab5) to head (94b163f).
Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
src/cli/fmt.rs 0.00% 25 Missing ⚠️
src/cli/tc/check.rs 0.00% 10 Missing ⚠️
src/cli/tc/helpers.rs 0.00% 9 Missing ⚠️
src/cli/tc/start.rs 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2644      +/-   ##
==========================================
- Coverage   87.49%   87.40%   -0.09%     
==========================================
  Files         263      263              
  Lines       26523    26549      +26     
==========================================
  Hits        23205    23205              
- Misses       3318     3344      +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Action required: PR inactive for 5 days.
Status update or closure in 10 days.

@github-actions github-actions bot added state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. and removed state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. labels Aug 16, 2024
@tusharmath tusharmath marked this pull request as draft August 16, 2024 09:57
@tusharmath
Copy link
Contributor

Lets connect on this when you are back.

Copy link

Action required: PR inactive for 5 days.
Status update or closure in 10 days.

@github-actions github-actions bot added the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Aug 21, 2024
@github-actions github-actions bot removed the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Aug 23, 2024
Copy link

Action required: PR inactive for 5 days.
Status update or closure in 10 days.

@github-actions github-actions bot added state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. and removed state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. labels Aug 28, 2024
Copy link

github-actions bot commented Sep 2, 2024

Action required: PR inactive for 5 days.
Status update or closure in 10 days.

@github-actions github-actions bot added state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. and removed state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. labels Sep 2, 2024
Copy link

github-actions bot commented Sep 7, 2024

Action required: PR inactive for 5 days.
Status update or closure in 10 days.

@github-actions github-actions bot added the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Sep 7, 2024
Copy link

PR closed after 10 days of inactivity.

@github-actions github-actions bot closed this Sep 17, 2024
@ssddOnTop ssddOnTop reopened this Oct 2, 2024
@ssddOnTop ssddOnTop marked this pull request as ready for review October 2, 2024 05:22
@ssddOnTop ssddOnTop removed the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Oct 2, 2024
Copy link

github-actions bot commented Oct 7, 2024

Action required: PR inactive for 5 days.
Status update or closure in 10 days.

@github-actions github-actions bot added state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. and removed state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. labels Oct 7, 2024
@meskill
Copy link
Contributor

meskill commented Oct 7, 2024

Do we really need to capture the output separately?

Consider this:

  • instead of calling some function from the lib we can start the binary programmatically and capture it's output.
  • also we can use different tracing crates to capture the output for testing, but I don't think making changes to the code to test the cli output is a good approach

@ssddOnTop
Copy link
Member Author

* instead of calling some function from the lib we can start the binary programmatically and capture it's output.

but is that a good approach?

we couldn't get codecov, if something throws an runtime error, we won't have much information about that.. etc

@meskill
Copy link
Contributor

meskill commented Oct 7, 2024

* instead of calling some function from the lib we can start the binary programmatically and capture it's output.

but is that a good approach?

we couldn't get codecov, if something throws an runtime error, we won't have much information about that.. etc

I believe it'd better represent end user experience and we will test the actual output instead of testing that some data has been written somewhere that won't mean the actual output (for testing TAILCALL_LOG).
Also, code coverage is possible for standalone binaries though it's probably not that easy to collect, agree

@ssddOnTop
Copy link
Member Author

I believe it'd better represent end user experience and we will test the actual output instead of testing that some data has been written somewhere that won't mean the actual output (for testing TAILCALL_LOG). Also, code coverage is possible for standalone binaries though it's probably not that easy to collect, agree

Okay.

Closing this PR and I'd raise new PR based on the suggestions.

@ssddOnTop ssddOnTop closed this Oct 7, 2024
@ssddOnTop ssddOnTop deleted the chore/make-fmt-capture-output branch October 7, 2024 13:50
@meskill
Copy link
Contributor

meskill commented Oct 7, 2024

I believe it'd better represent end user experience and we will test the actual output instead of testing that some data has been written somewhere that won't mean the actual output (for testing TAILCALL_LOG). Also, code coverage is possible for standalone binaries though it's probably not that easy to collect, agree

Okay.

Closing this PR and I'd raise new PR based on the suggestions.

Please discuss first with @tusharmath about the approach

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: chore Routine tasks like conversions, reorganization, and maintenance work.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants