Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(2483): Add @modify to work on input fields #2524

Closed
wants to merge 36 commits into from

Conversation

karatakis
Copy link
Collaborator

@karatakis karatakis commented Jul 25, 2024

Summary:
Make @modify work for input fields

Issue Reference(s):
Fixes #2483

Build & Testing:

  • I ran cargo test successfully.
  • I have run ./lint.sh --mode=fix to fix all linting issues raised by ./lint.sh --mode=check.

Checklist:

  • I have added relevant unit & integration tests.
  • I have updated the documentation accordingly.
  • I have performed a self-review of my code.
  • PR follows the naming convention of <type>(<optional scope>): <title>

@github-actions github-actions bot added the type: fix Iterations on existing features or infrastructure. label Jul 25, 2024
@karatakis
Copy link
Collaborator Author

To make it better integrated with IR infrastructure, I propose to replace pub renames: HashMap<Vec<String>, String> with pub renames: HashMap<Vec, Option>and collect the IR of all subfields of an input type, with the addition of a fieldpub resolver: Optionfor the self operations. All the changes should be performed at theInputFieldDefinition` struct.

Copy link

codecov bot commented Jul 25, 2024

Codecov Report

Attention: Patch coverage is 80.32787% with 48 lines in your changes missing coverage. Please review.

Project coverage is 87.07%. Comparing base (5f0032d) to head (cd8ceef).
Report is 102 commits behind head on main.

Files with missing lines Patch % Lines
src/core/json/json_lens.rs 45.65% 25 Missing ⚠️
src/core/blueprint/input_field_resolver.rs 95.26% 8 Missing ⚠️
src/core/json/borrow.rs 0.00% 7 Missing ⚠️
src/core/json/serde.rs 0.00% 6 Missing ⚠️
src/core/ir/eval.rs 83.33% 1 Missing ⚠️
src/core/json/graphql.rs 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2524      +/-   ##
==========================================
- Coverage   87.13%   87.07%   -0.07%     
==========================================
  Files         254      256       +2     
  Lines       25144    25388     +244     
==========================================
+ Hits        21910    22107     +197     
- Misses       3234     3281      +47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@karatakis karatakis changed the title Fix(#2483): Fix @modify to work on input fields feat(#2483): Add @modify to work on input fields Jul 25, 2024
@github-actions github-actions bot added the type: feature Brand new functionality, features, pages, workflows, endpoints, etc. label Jul 25, 2024
@karatakis karatakis added ci: test-jit Run all integration tests for the JIT optimized engine and removed ci: test-jit Run all integration tests for the JIT optimized engine labels Jul 25, 2024
@karatakis
Copy link
Collaborator Author

After playing with the IR approach, it needs a custom InputFieldEvaluator. Feel free to comment if we want this approach instead of the hardcoded solution I provided.

@tusharmath tusharmath marked this pull request as draft July 26, 2024 06:20
@karatakis karatakis marked this pull request as ready for review July 26, 2024 14:08
@karatakis karatakis marked this pull request as draft July 26, 2024 14:29
@karatakis karatakis marked this pull request as ready for review July 26, 2024 17:08
src/core/blueprint/into_schema.rs Outdated Show resolved Hide resolved
src/core/ir/model.rs Outdated Show resolved Hide resolved
@karatakis karatakis marked this pull request as ready for review August 20, 2024 16:36
Copy link

Action required: PR inactive for 5 days.
Status update or closure in 10 days.

@github-actions github-actions bot added the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Aug 25, 2024
@karatakis
Copy link
Collaborator Author

karatakis commented Aug 26, 2024

The PR is waiting review

@github-actions github-actions bot removed the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Aug 26, 2024
@tusharmath tusharmath enabled auto-merge (squash) August 27, 2024 16:53
@tusharmath tusharmath marked this pull request as draft August 30, 2024 12:31
@tusharmath
Copy link
Contributor

@karatakis Like discussed, we should more the lens capabilities out of the core transformation capabilities.

Copy link

github-actions bot commented Sep 4, 2024

Action required: PR inactive for 5 days.
Status update or closure in 10 days.

@github-actions github-actions bot added the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Sep 4, 2024
@github-actions github-actions bot removed the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Sep 9, 2024
@karatakis karatakis marked this pull request as ready for review September 10, 2024 23:52
Copy link

Action required: PR inactive for 5 days.
Status update or closure in 10 days.

@github-actions github-actions bot added state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. and removed state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. labels Sep 16, 2024
Copy link

Action required: PR inactive for 5 days.
Status update or closure in 10 days.

@github-actions github-actions bot added the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Sep 21, 2024
Copy link

github-actions bot commented Oct 1, 2024

PR closed after 10 days of inactivity.

@github-actions github-actions bot closed this Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. type: feature Brand new functionality, features, pages, workflows, endpoints, etc. type: fix Iterations on existing features or infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support @modify on inputs
3 participants