Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support list args in query params #2365

Merged
merged 65 commits into from
Jul 11, 2024

Conversation

laststylebender14
Copy link
Contributor

@laststylebender14 laststylebender14 commented Jul 7, 2024

Summary:
Briefly describe the changes made in this PR.

Issue Reference(s):
Fixes #... (Replace "..." with the issue number)

Build & Testing:

  • I ran cargo test successfully.
  • I have run ./lint.sh --mode=fix to fix all linting issues raised by ./lint.sh --mode=check.

Checklist:

  • I have added relevant unit & integration tests.
  • I have updated the documentation accordingly.
  • I have performed a self-review of my code.
  • PR follows the naming convention of <type>(<optional scope>): <title>

@github-actions github-actions bot added the ci: benchmark Runs benchmarks label Jul 9, 2024
@laststylebender14 laststylebender14 removed the ci: benchmark Runs benchmarks label Jul 9, 2024
@laststylebender14 laststylebender14 marked this pull request as draft July 9, 2024 10:07
@laststylebender14 laststylebender14 marked this pull request as ready for review July 9, 2024 10:27
@tusharmath tusharmath changed the base branch from feat/add-support-for-list-argument-types to main July 10, 2024 14:40
@github-actions github-actions bot added the ci: benchmark Runs benchmarks label Jul 10, 2024
Copy link

codecov bot commented Jul 10, 2024

Codecov Report

Attention: Patch coverage is 99.78118% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.52%. Comparing base (639d118) to head (df8f730).

Files Patch % Lines
src/core/http/request_template.rs 98.70% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2365      +/-   ##
==========================================
+ Coverage   87.26%   87.52%   +0.25%     
==========================================
  Files         243      244       +1     
  Lines       22524    22942     +418     
==========================================
+ Hits        19656    20079     +423     
+ Misses       2868     2863       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jul 10, 2024

🐰Bencher

ReportThu, July 11, 2024 at 05:04:15 UTC
Projecttailcall
Branch2365/merge
Testbedbenchmarking-runner
Click to view all benchmark results
BenchmarkLatencyLatency Results
nanoseconds (ns) | (Δ%)
Latency Upper Boundary
nanoseconds (ns) | (%)
from_json_bench✅ (view plot)6,138,800.00 (-10.73%)7,784,736.84 (78.86%)
group_by✅ (view plot)485.12 (-11.89%)624.62 (77.67%)
input/args.missing✅ (view plot)25.44 (+5.16%)27.74 (91.70%)
input/args.nested.existing✅ (view plot)44.33 (-6.49%)61.07 (72.59%)
input/args.nested.missing✅ (view plot)37.93 (-0.27%)40.83 (92.91%)
input/args.root✅ (view plot)39.79 (-9.03%)57.99 (68.62%)
input/headers.existing✅ (view plot)32.58 (+2.91%)34.05 (95.67%)
input/headers.missing✅ (view plot)31.86 (+3.50%)33.91 (93.95%)
input/value.missing✅ (view plot)23.35 (-0.26%)24.96 (93.55%)
input/value.nested.existing✅ (view plot)43.11 (+3.43%)45.18 (95.41%)
input/value.nested.missing✅ (view plot)37.81 (+2.32%)39.60 (95.48%)
input/value.root✅ (view plot)38.25 (+0.96%)41.40 (92.40%)
input/vars.existing✅ (view plot)8.35 (+8.31%)9.10 (91.74%)
input/vars.missing✅ (view plot)8.03 (-19.90%)13.43 (59.77%)
synth_nested✅ (view plot)157,190.00 (+135.70%)204,605.95 (76.83%)
test_batched_body✅ (view plot)1,992.30 (-93.43%)483,632.52 (0.41%)
test_batched_body #2✅ (view plot)1,622,600.00 (-4.20%)1,817,052.57 (89.30%)
test_data_loader✅ (view plot)365,120.00 (-19.93%)525,354.87 (69.50%)
test_handle_request✅ (view plot)142,900.00 (-7.37%)172,448.90 (82.87%)
test_handle_request_jit✅ (view plot)91,217.00 (-0.53%)94,928.22 (96.09%)
test_http_execute_method✅ (view plot)14,198.00 (-18.68%)20,720.83 (68.52%)
with_mustache_expressions✅ (view plot)1,109.00 (-4.37%)1,237.31 (89.63%)
with_mustache_literal✅ (view plot)741.99 (+2.69%)779.51 (95.19%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

@tusharmath tusharmath changed the title feat: improve design of list args feat: support list args in query params Jul 11, 2024
@tusharmath tusharmath merged commit 2ce5e3a into main Jul 11, 2024
36 checks passed
@tusharmath tusharmath deleted the feat/improve-design-of-list-args branch July 11, 2024 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci: benchmark Runs benchmarks type: feature Brand new functionality, features, pages, workflows, endpoints, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants