Skip to content

Pass in dynamic callbacks #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
joshr4 wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Pass in dynamic callbacks #26

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 11 additions & 18 deletions src/core.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,9 +128,15 @@ export function useNostr() {
export function useNostrEvents({
filter,
enabled = true,
onEvent,
onDone,
onSubscribe,
}: {
filter: Filter
enabled?: boolean
onEvent?: OnEventFunc
onDone?: OnDoneFunc
onSubscribe?: OnSubscribeFunc
}) {
const {
isLoading: isLoadingProvider,
Expand All @@ -145,9 +151,11 @@ export function useNostrEvents({
return
})

let onEventCallback: null | OnEventFunc = null
let onSubscribeCallback: null | OnSubscribeFunc = null
let onDoneCallback: null | OnDoneFunc = null
const onEventCallback: OnEventFunc = useCallback(onEvent, [onEvent])
const onSubscribeCallback: OnSubscribeFunc = useCallback(onSubscribe, [
onSubscribe,
])
const onDoneCallback: OnDoneFunc = useCallback(onDone, [onDone])

// Lets us detect changes in the nested filter object for the useEffect hook
const filterBase64 =
Expand Down Expand Up @@ -226,20 +234,5 @@ export function useNostrEvents({
onConnect,
connectedRelays,
unsubscribe,
onSubscribe: (_onSubscribeCallback: OnSubscribeFunc) => {
if (_onSubscribeCallback) {
onSubscribeCallback = _onSubscribeCallback
}
},
onEvent: (_onEventCallback: OnEventFunc) => {
if (_onEventCallback) {
onEventCallback = _onEventCallback
}
},
onDone: (_onDoneCallback: OnDoneFunc) => {
if (_onDoneCallback) {
onDoneCallback = _onDoneCallback
}
},
}
}