Fix parsing of X-Forwarded-For header when trustAnyForwardedAddress is enabled #611
+45
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solve a parsing error when `trustAnyForwardedAddress` is enabled. This is caused by the `X-Forwarded-For` header containing an IP address, and not a host+port.
The current logs contain only the original host and remote address. This makes it difficult to see who actually performed the request without correlating other logs. Add these values to the log context in addition to the original values.
Add the subject that is rate limited to the logged entry.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves a parsing error when
trustAnyForwardedAddressis enabled. This is caused by theX-Forwarded-Forheader containing an IP address, and not a host+port. This causes the split to fail withmissing port in addressortoo many colons in address, leading in the feature not actually working.Additionally, I've included two minor enhancements in the logging: