Add new event, fix typo #466
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis build is failed ...is it because of "TBD" date in new event instead of regular date format? PS yeah i guess so. how to fix it? |
|
Yes, that's the problem. Currently we don't support events without dates. Someone started to work on a proposal to allow for such events, but I think he has not sent a PR for it. He has not even opened an issue with this. For now send a separate PR fixing the jsconf issue starting with a new branch from the I've created an issue describing the idea: #467 |
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new event nodeconf-usa-2018, fix typo(delete link to code of conduct,was a link to videos) in jsconf-co-2015