feat(fdtable): add CLOEXEC flag #162
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stone749990226
force-pushed
the
dev
branch
3 times, most recently
from
2db9013 to
5ead86a
Compare
ken4647
reviewed
Jan 20, 2025
chore: apply code style fixes and update documentation
ken4647
reviewed
Jan 21, 2025
| @@ -61,19 +62,20 @@ pub fn get_file_like(fd: i32) -> LinuxResult<Arc<dyn FileLike>> { | |||
| } | |||
|
|
|||
| /// Adds a file like object to the file descriptor table and returns the file descriptor. | |||
| pub fn add_file_like(f: Arc<dyn FileLike>) -> LinuxResult<i32> { | |||
| pub fn add_file_like(f: Arc<dyn FileLike>, flags: usize) -> LinuxResult<i32> { | |||
There was a problem hiding this comment.
it is better to use a enum type instead of usize for this flags, as it is a interface for kernel inside. Using a enum type make it more meaningful.
There was a problem hiding this comment.
there is a data structre named OpenOption in modules/ruxfs/src/fops.rs , I think it may be more suitable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for the CLOEXEC flag in file descriptors.