add inter-vm conmmunication on hvisor #153
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ken4647
reviewed
Dec 5, 2024
|
Another question is that the implementation of the Connection struct in modules/ruxhal/src/platform/aarch64_common/ivc.rs in this PR seems irrelevant to the CPU architecture. Why not move it out of the platform directory? |
HeartLinked
force-pushed
the
dev
branch
2 times, most recently
from
d4d30af to
b42108b
Compare
ken4647
reviewed
Dec 11, 2024
| info!("Message written to shared memory: {}", message); | ||
|
|
||
| // Get a mutable reference to ControlTable to modify ipi_invoke | ||
| let control_table = unsafe { control_table_ptr.as_mut() }; |
There was a problem hiding this comment.
Does this API support parallel execution? Is the implementation thread-safe?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add inter-vm conmmunication on hvisor.