Improve profile validation #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jensschuppe
reviewed
Aug 16, 2023
jensschuppe
added
enhancement
jensschuppe
force-pushed
the
improve_validation
branch
from
ad1ecec to
6114772
Compare
jensschuppe
added
status:fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I moved the whole profile validation into the
CRM_Twingle_Profileclass. I also added some new checks for:Spaces are now allowed in profile names.
This PR depends on PRs #72 and #73 because custom
ProfileValidationErrorclass is used and profiles are referred to by their id!