Onboarding V4 - Hetzner & DigitalOcean #7763
Merged
+1,018
−969
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or OpenSSF Scorecard issues found.Scanned FilesNone |
wendybujalski
force-pushed
the
wendy/eng-3283-onboarding-vnext
branch
from
8e79d33 to
35a750a
Compare
wendybujalski
requested review from
jobelenus,
nickgerace,
stack72 and
vbustamante
wendybujalski
commented
Nov 13, 2025
Comment on lines
16
to
21
| <div class="relative flex flex-col items-center translate-y-[26px]"> | ||
| <Icon :name="icon" size="none" :class="iconClasses" /> | ||
| <div | ||
| :class=" | ||
| clsx( | ||
| !beta && 'invisible', | ||
| 'border text-xs p-2xs rounded-sm', | ||
| themeClasses( | ||
| 'border-action-300 bg-action-100', | ||
| 'border-action-500 bg-action-900', | ||
| ), | ||
| ) | ||
| " | ||
| > | ||
| Beta | ||
| </div> | ||
| </div> |
Contributor
Author
There was a problem hiding this comment.
To make the Beta tag appear nicely for any provider, it is positioned below the icon and then the div containing both is translated back to its centered position.
wendybujalski
commented
Nov 13, 2025
Comment on lines
+3
to
+8
| // To add a new provider to this onboarding flow, search for this string - | ||
| // NEW_PROVIDER_STEPS | ||
| // And add the required information at each spot | ||
| // You will also need to edit the onboarding endpoint to support the new provider | ||
| // Find it here - | ||
| // lib/sdf-server/src/service/v2/change_set/create_initialize_apply.rs |
Contributor
Author
There was a problem hiding this comment.
Helpful instructions for adding a new provider!
wendybujalski
commented
Nov 13, 2025
Comment on lines
+26
to
+28
| // Toggle this to turn onboarding on but not in debug mode | ||
| // Allows full functional testing of the onboarding flow | ||
| export const FORCE_ONBOARDING_TO_SHOW = false; |
Contributor
Author
There was a problem hiding this comment.
This allows us to test the functionality of onboarding even while using an account which has finished it.
wendybujalski
commented
Nov 13, 2025
| class="flex flex-col items-center w-full h-full min-w-[900px] relative scrollable" | ||
| > | ||
| <!-- Header --> | ||
| <div class="w-full h-full scrollable scrollable-horizontal"> |
Contributor
Author
There was a problem hiding this comment.
The onboarding now does not break when the screen size is too small.
The onboarding has a minimum width, which depends on the number of providers.
wendybujalski
commented
Nov 13, 2025
| <OnboardingStepBlock v-if="providerChoice === 'AWS'"> | ||
| <template v-else> | ||
| <div class="flex-1 flex flex-col basis-1/2 min-w-0"> | ||
| <!-- Step 2: Provider setup --> |
Contributor
Author
There was a problem hiding this comment.
All providers now use this same OnboardingStepBlock with swapped around text/icons/data and some sections specific to a provider.
wendybujalski
commented
Nov 13, 2025
| class="flex flex-row items-center justify-between text-sm" | ||
| > | ||
| <div> | ||
| <div v-if="providerChoice === 'AWS'"> |
Contributor
Author
There was a problem hiding this comment.
Currently we only support this bash env paste for AWS.
wendybujalski
commented
Nov 13, 2025
| </div> | ||
| <!-- Secret Values --> | ||
| <ErrorMessage | ||
| v-if="providerChoice !== 'Hetzner'" |
Contributor
Author
There was a problem hiding this comment.
Hetzner only has one field so no reason to include this banner.
wendybujalski
commented
Nov 13, 2025
| <div class="flex flex-col"> | ||
| <span | ||
| >Install | ||
| <!-- Step 3: Agent Tutorial + token --> |
Contributor
Author
There was a problem hiding this comment.
This part of the onboarding did not change.
wendybujalski
commented
Nov 13, 2025
| const decrementOnboardingStep = () => { | ||
| currentStep.value = Math.max( | ||
| OnboardingStep.INITIALIZE, | ||
| OnboardingStep.PICK_PROVIDER, |
Contributor
Author
There was a problem hiding this comment.
Fixes a bug where you could not go back to the provider selection page!
wendybujalski
commented
Nov 13, 2025
Comment on lines
+1238
to
+1303
| "Subscription ID": { | ||
| ref: "", | ||
| type: "password", | ||
| required: true, | ||
| }, |
Contributor
Author
There was a problem hiding this comment.
Added this field to the Azure secret form instead of having it separate.
wendybujalski
force-pushed
the
wendy/eng-3283-onboarding-vnext
branch
from
35a750a to
9e39ad8
Compare
wendybujalski
force-pushed
the
wendy/eng-3283-onboarding-vnext
branch
from
9e39ad8 to
93dbf8d
Compare
jobelenus
previously approved these changes
Nov 13, 2025
stack72
reviewed
Nov 13, 2025
| "AWS Credential", | ||
| "/secrets/AWS Credential", | ||
| "Region", | ||
| Some("Region"), |
stack72
reviewed
Nov 13, 2025
| "Microsoft Credential", | ||
| "/secrets/Microsoft Credential", | ||
| "Microsoft.Resources/locations", | ||
| Some("Microsoft.Resources/locations"), |
stack72
previously approved these changes
Nov 13, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
wendybujalski
force-pushed
the
wendy/eng-3283-onboarding-vnext
branch
from
93dbf8d to
b3b7bca
Compare
wendybujalski
changed the title
wendybujalski
dismissed stale reviews from jobelenus and stack72
via
0076bc8
wendybujalski
force-pushed
the
wendy/eng-3283-onboarding-vnext
branch
3 times, most recently
from
e925394 to
c8d0dc4
Compare
wendybujalski
changed the title
wendybujalski
force-pushed
the
wendy/eng-3283-onboarding-vnext
branch
2 times, most recently
from
799c58c to
0526db4
Compare
jobelenus
approved these changes
Nov 14, 2025
How does this PR change the system? This PR updates the onboarding flow to support Hetzner and DigitalOcean It also revamps and refactors the onboarding flow code to make adding new providers even simpler The DigitalOcean option in onboarding is behind a feature flag so we can wait to roll it out until the DigitalOcean assets are ready for users Out of Scope: We will be adding additional providers to the onboarding as we support them. How was it tested? Ran through the onboarding for each provider successfully! Double checked all the copy and design.
wendybujalski
force-pushed
the
wendy/eng-3283-onboarding-vnext
branch
from
0526db4 to
da26a1c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How does this PR change the system?
This PR updates the onboarding flow to support Hetzner and DigitalOcean
It also revamps and refactors the onboarding flow code to make adding new providers even simpler
The DigitalOcean option in onboarding is behind a feature flag so we can wait to roll it out until the DigitalOcean assets are ready for users
Completes ENG-3283
Screenshots:
Out of Scope:
We will be adding additional providers to the onboarding as we support them.
How was it tested?
Ran through the onboarding for each provider successfully!
Double checked all the copy and design.