Skip to content

Conversation

@jobelenus
Copy link
Contributor

Let's stop having multiple components mutate the query string

How does this PR change the system?

Here is the scenario:

  1. the search box on the explore page changes the URL
  2. the same search box on the map page does not change the URL
  3. so when you clear the search box on the map page, and click on a component, the router push for that component keeps the search terms in the URL
  4. which on URL change re-inserts the query string into the search box and filters the components

The Explore component has a watcher that changes the query string for the search text from the input box. The Map component also has a watcher that fires at the same time. It doesn't know anything about the search text. So it gets clobbered.

Out of Scope:

Other deleted code inside the watcher is covered off by the rest of the implementation.

How was it tested?

Searching and selecting components on the Map

@github-actions
Copy link

github-actions bot commented Oct 7, 2025

Dependency Review

✅ No vulnerabilities or OpenSSF Scorecard issues found.

Scanned Files

None

@github-actions github-actions bot added the A-web label Oct 7, 2025
@jobelenus jobelenus added this pull request to the merge queue Oct 7, 2025
Merged via the queue into main with commit a79b255 Oct 7, 2025
10 checks passed
@jobelenus jobelenus deleted the jobelenus/BUG-1039 branch October 7, 2025 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants