feat(RBE): only enable if SI_RBE_TOKEN is set #7458
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or OpenSSF Scorecard issues found.Scanned FilesNone |
|
/try |
|
Okay, starting a try! I'll update this comment once it's running... |
|
/try |
github-actions
bot
added
A-sdf
|
Okay, starting a try! I'll update this comment once it's running... |
wendybujalski
approved these changes
Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How does this PR change the system?
Disable RBE by default. Enable it if the
SI_RBE_TOKENenv var is set.This is done by using the nix flake to write a secondary buckconfig file that sets a value we check when setting up RBE.
How was it tested?
Locally. This will rebuild the world, so if all of those tests pass this should be okay.
In short: 🔗