feat: parallel execution of validations #5576
Open
+25
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR runs all validations in parallel, rather than in serial. The result is that initial validation runs feel pretty much instantaneous.
Dependency Review✅ No vulnerabilities or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
jkeiser
reviewed
Feb 28, 2025
| let value = AttributeValue::get_by_id(ctx, av_id) | ||
| .await? | ||
| .value(ctx) | ||
| let ctx_clone = ctx.clone(); |
There was a problem hiding this comment.
Most places I've seen we just use the same variable name (makes the code read the same whether it's in the block or not.)
Suggested change
| let ctx_clone = ctx.clone(); | |
| let ctx = ctx.clone(); |
|
Do I assume correctly that this change means that we're sure all validations are independent of each other and can run concurrently? Could there possibly be a case where two validations would affect each other when running in parallel? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR runs all validations in parallel, rather than in serial. The result is that initial validation runs feel pretty much instantaneous.