Add support for building UKIProfiles initrds with extra packages#4142
Add support for building UKIProfiles initrds with extra packages#4142bluca wants to merge 1 commit intosystemd:mainfrom
Conversation
bluca
force-pushed
the
uki_profile_initrd
branch
from
dec005f to
532c49a
Compare
If Packages= is specifed under a UKI profile, take the 'main' initrd and add the new packages on top of it, and use that as the profile's initrd. Profile's sections are complete replacements, they are not additive, so it needs to be the full thing.
bluca
force-pushed
the
uki_profile_initrd
branch
from
532c49a to
06f0097
Compare
| `.cmdline` section and the extra kernel command line arguments | ||
| specified with this setting. | ||
|
|
||
| `Packages=` |
There was a problem hiding this comment.
So while this does end in it's own structure in the config, I think calling this Packages= has the (only very slight!) potential for hard to debug errors, since during config parsing we do pass around dictionaries.
More importantly, though, we already have InitrdPackages= which would make this a bit confusing, since that's for the packages in the initrd.
How about ExtraInitrdPackages= to clearly communicate that this is different and that this is additive?
There was a problem hiding this comment.
I'd rather leave it as-is, given it's a different section and it has the same syntax as the other it seems clearer. More importantly OBS won't parse a new setting for dependency resolution, so that would be a massive pain to change
|
I doubt we should do this until we have a mechanism in systemd to make these overlays on top of the main initrd given the size increases you get otherwise, closing for now, feel free to reopen if you disagree. |
|
Lennart doesn't want to have the initrd profile overlay thingy so that won't happen. Given it's optional and one has to actually configure it, it should be fine to just add it? There's no cost to anybody not configuring packages in the profile |
|
I'd prefer to not have to maintain code that nobody will end up using due to various limitations |
3 participants
If Packages= is specifed under a UKI profile, take the 'main' initrd and add the new packages on top of it, and use that as the profile's initrd. Profile's sections are complete replacements, they are not additive, so it needs to be the full thing.