-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sandbox: introduce the MKOSI_CHROOT_SUPPRESS_CHOWN variable #2986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaanDeMeyer
requested changes
Aug 28, 2024
behrmann
force-pushed
the
nochown
branch
2 times, most recently
from
August 29, 2024 09:06
cd7be6c
to
e04a568
Compare
DaanDeMeyer
requested changes
Aug 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, two minor things
behrmann
force-pushed
the
nochown
branch
2 times, most recently
from
August 29, 2024 09:52
8e4360a
to
1b7c0c8
Compare
DaanDeMeyer
requested changes
Aug 29, 2024
DaanDeMeyer
requested changes
Aug 29, 2024
DaanDeMeyer
reviewed
Aug 29, 2024
This allows suppressing chowns in scripts. Also inline chroot_script_cmd since it only as a single user.
DaanDeMeyer
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows suppressing chowns in scripts.