Skip to content

scripts: Update deps.sh #519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 12, 2025
Merged

scripts: Update deps.sh #519

merged 1 commit into from
Mar 12, 2025

Conversation

crawfxrd
Copy link
Member

  • Use distro-provided rustup package on Fedora, Arch
  • Use sh compatible commands where possible
  • Update command for installing pinned Rust toolchain
  • Remove progress messages
  • Remove commands that conflict with running the script in other contexts
    • git-hooks breaks calling from firmware-open directory
    • submodule checkout is only required for external flashing and for generating initial board configs from firmware-open

@crawfxrd
scripts: Update deps.sh
1fe4dce 
- Use distro-provided rustup package on Fedora, Arch
- Use sh compatible commands where possible
- Update command for installing pinned Rust toolchain
- Remove progress messages
- Remove commands that conflict with running the script in other contexts
  - git-hooks breaks calling from firmware-open directory
  - submodule checkout is only required for external flashing and for
    generating initial board configs from firmware-open

Signed-off-by: Tim Crawford <[email protected]>
@crawfxrd crawfxrd requested review from a team March 11, 2025 15:56
@jacobgkau jacobgkau self-assigned this Mar 12, 2025
jacobgkau
jacobgkau approved these changes Mar 12, 2025
View reviewed changes
Copy link
Member

@jacobgkau jacobgkau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still works on Pop!_OS 22.04 & 24.04. New Arch & Fedora package names are correct. Now works when run from firmware-open directory where it didn't before.

@crawfxrd crawfxrd merged commit 05744ac into master Mar 12, 2025
48 checks passed
@crawfxrd crawfxrd deleted the deps-script branch March 12, 2025 18:53
@crawfxrd crawfxrd mentioned this pull request Mar 12, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobgkau jacobgkau jacobgkau approved these changes

@jackpot51 jackpot51 jackpot51 approved these changes

Assignees

@jacobgkau jacobgkau

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crawfxrd @jacobgkau @jackpot51