Skip to content

Comments

kbc: Support get scancode command sequence#517

Merged
jackpot51 merged 1 commit intosystem76:masterfrom
phcoder:getscan
Nov 17, 2025
Merged

kbc: Support get scancode command sequence#517
jackpot51 merged 1 commit intosystem76:masterfrom
phcoder:getscan

Conversation

@phcoder
Copy link
Contributor

@phcoder phcoder commented Feb 25, 2025

This improves compatibility with PS/2 protocol.

This improves compatibility with PS/2 protocol.
@jackpot51 jackpot51 requested a review from a team February 25, 2025 15:48
Copy link
Member

@leviport leviport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on my oryp9. Not seeing any adverse effects.

@crawfxrd
Copy link
Member

oryp9 has psmouse blacklisted in system76-driver. Was psmouse loaded?

@leviport
Copy link
Member

It would show up in my boot parameters if it were, right? I'm not seeing it:

kernelstub.Config    : INFO     Looking for configuration...
kernelstub           : INFO     System information:

    OS:..................Pop!_OS 24.04
    Root partition:....../dev/dm-1
    Root FS UUID:........89cd8435-ab39-4ceb-8807-c29029712205
    ESP Path:............/boot/efi
    ESP Partition:......./dev/nvme1n1p1
    ESP Partition #:.....1
    NVRAM entry #:.......-1
    Boot Variable #:.....0000
    Kernel Boot Options:.systemd.show_status=false loglevel=0 quiet splash
    Kernel Image Path:.../boot/vmlinuz-6.17.4-76061704-generic
    Initrd Image Path:.../boot/initrd.img-6.17.4-76061704-generic
    Force-overwrite:.....False

kernelstub           : INFO     Configuration details:

   ESP Location:................../boot/efi
   Management Mode:...............True
   Install Loader configuration:..True
   Configuration version:.........3

Is there a different model that would be better to test this on?

@crawfxrd
Copy link
Member

It's set by modprobe options. You can do lsmod | grep psmouse to check if it's loaded. It's probably best to test on a model that has it currently blacklisted (by removing it from the modprobe options and regenerating initramfs), because we know it has issues.

Otherwise, anything in system76driver/products.py with remove_blacklist_psmouse or without any psmouse action.

@leviport
Copy link
Member

I also gave this a test on darp10-b since it has remove_blacklist_psmouse. I confirmed that psmouse was not blacklisted since it showed up in lsmod | grep psmouse, and I ran some typing tests. Keyboard behavior seems perfectly normal with this change.

@jackpot51 jackpot51 merged commit ac637f4 into system76:master Nov 17, 2025
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants