fix: xpath filter passed to 'get_changes' #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an xpath is set then the sysrepo API already provides only filtered changes. Reapplying the same xpath doesn't work when the filter element is not part of the result. Hence, remove all filters when collecting the changes. For example, the xpath "/ietf-interfaces:interfaces/interface[type='iana-if-type:ethernetCsmacd']/enabled" subscribes for changes of the 'enabled' leaf but 'type' is not part of the result, in which case get_changes(xpath + '//.', ...) will always be empty! Hence, remove any filter conditions from the xpath!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an xpath is set then the sysrepo API already provides only filtered changes. Reapplying the same xpath doesn't work when the filter element is not part of the result. Hence, remove all filters when collecting the changes.
For example, the xpath "/ietf-interfaces:interfaces/interface[type='iana-if-type:ethernetCsmacd']/enabled" subscribes for changes of the 'enabled' leaf but 'type' is not part of the result, in which case get_changes(xpath + '//.', ...) will always be empty!
Hence, we need to remove any filter conditions from the xpath when collecting changes.
@rjarry Can you please review and, if accepted, merge?