Implement dynamic MCS selection based on signal strength in vWIFI driver #80

dingsen-Greenhorn · 2025-06-07T20:19:57Z

This commit enhances the vWIFI driver by implementing dynamic Modulation and Coding Scheme (MCS) selection in the vwifi_get_station function, adjusting the MCS index based on signal strength

After implement dynamic MCS can avoid TX power waste for a bad channel quality

jserv

Follow the consistent coding style.

jychen0611

It seems that you are adjusting the MCS based on the current signal strength. However, what if a user wants to set the MCS manually using a command like iw dev wlan0 set bitrates ht-mcs-2.4 <mcs_index>?

To support this, you could consider implementing the set_bitrate_mask() callback in your cfg80211_ops and storing the specified MCS in the corresponding vwifi interface structure.

dingsen-Greenhorn · 2025-06-08T06:43:49Z

It seems that you are adjusting the MCS based on the current signal strength. However, what if a user wants to set the MCS manually using a command like iw dev wlan0 set bitrates ht-mcs-2.4 <mcs_index>?

To support this, you could consider implementing the set_bitrate_mask() callback in your cfg80211_ops and storing the specified MCS in the corresponding vwifi interface structure.

Thanks for you suggestion ,I can try to included the MCS for maunally adjust !

jychen0611

Can you explain in more detail how your design handles MCS settings? In particular, the MCS formula.

Also, why is the MCS index constrained to 7, 15, 23 and 31? Please clarify the reasoning behind these limits.

jychen0611 · 2025-06-08T15:41:09Z

vwifi.c

@@ -88,6 +88,8 @@ struct vwifi_vif {
    struct wireless_dev wdev;
    struct net_device *ndev;
    struct net_device_stats stats;
+    int manual_mcs;      /* ADDED: Store user-specified MCS */


Remove "ADDED:" prefix from the comment

jychen0611 · 2025-06-08T15:41:46Z

vwifi.c

@@ -88,6 +88,8 @@ struct vwifi_vif {
    struct wireless_dev wdev;
    struct net_device *ndev;
    struct net_device_stats stats;
+    int manual_mcs;      /* ADDED: Store user-specified MCS */
+    bool manual_mcs_set; /* ADDED: Flag to indicate manual MCS override */


Remove "ADDED:" prefix from the comment

jychen0611 · 2025-06-08T15:45:38Z

vwifi.c

@@ -1728,13 +1743,8 @@ static int vwifi_start_ap(struct wiphy *wiphy,

    /* Initialize hrtimer of beacon */
    pr_info("vwifi: init beacon_timer.\n");
-#if LINUX_VERSION_CODE >= KERNEL_VERSION(6, 15, 0)


Don't modify unrelated code segment!
You should align with the latest version of vwifi.

dingsen-Greenhorn · 2025-06-08T17:02:23Z

Can you explain in more detail how your design handles MCS settings? In particular, the MCS formula.

Also, why is the MCS index constrained to 7, 15, 23 and 31? Please clarify the reasoning behind these limits.

First,the code handles MCS selection and modulation assignment, either manually (based on vif->manual_mcs_set and vif->manual_mcs) or automatically (based on signal strength).

Second,The vWIFI driver constrains MCS indices to 7, 15, 23, and 31 to simplify rate calculation, testing, and implementation. This avoids the need for a comprehensive calculation of data-rates to handle all 32 MCS indices, varying streams, and channel widths. The chosen indices represent a range of modulations (BPSK to 64-QAM) for 4 streams, supporting both manual (iw commands) and automatic (signal-based) modes. The code’s design prioritizes simplicity for a virtual driver, ensuring functionality (as shown in your test output) while limiting complexity.

And thanks for you thoughtful question,it might be the next PR to optimize it !

EricccTaiwan · 2025-06-08T21:17:40Z

Nit: It might be better to squash all the “Fix coding style” commits.

jychen0611 · 2025-06-10T06:40:09Z

scripts/hostapd.conf

@@ -2,7 +2,7 @@ interface=vw0
 driver=nl80211
 debug=1
 ctrl_interface=/var/run/hostapd
-ctrl_interface_group=0
+ctrl_interface_group=root


The changes to the MCS configuration logic and the hostapd.conf control group setting serve different purposes and should be separated into distinct PRs.

The MCS logic affects runtime behavior of the vwifi driver, while the ctrl_interface_group=root change only impacts permission control for the hostapd socket.

Splitting them would improve clarity, ease future debugging, and allow better tracking of changes.

jychen0611 · 2025-06-10T07:27:12Z

vwifi.c

+    const char *modulation;
+    if (vif->manual_mcs_set) {
+        mcs_index = vif->manual_mcs;
+        switch (mcs_index) {


According to IEEE 802.11n, MCS indices 7, 15, 23, and 31 all use 64-QAM modulation.
You should revise the descriptions associated with each MCS index accordingly, or consider modifying your design if your intention was to differentiate based on modulation type.

ref:
mcsindex

dingsen-Greenhorn · 2025-06-12T16:23:25Z

first is auto selection MCS ,and manual assign three difference MCS for test.

jychen0611

Why is there a shell script embedded in the kernel module???
Use command

$ clang-format -i *.[ch]

to maintain a consistent coding style in your implementation!

jychen0611 · 2025-06-12T16:24:54Z

vwifi.c

-    {                              \
-        .bitrate = (_rate),        \
-        .hw_value = (_hw_value),   \
+for file in ${SOURCES}


Why is there a shell script embedded in the kernel module???
Use command

$ clang-format -i *.[ch]

to maintain a consistent coding style in your implementation!

EricccTaiwan · 2025-06-08T21:13:11Z

vwifi.c

+    /* Checks vif->manual_mcs_set to use vif->manual_mcs if set;
+     * Assigns modulation string for manual MCS ; else auto change based


~~Nit: Use imperative mood~~
Edit: solved

EricccTaiwan · 2025-06-13T19:04:14Z

vwifi.c

@@ -1403,8 +1403,19 @@ static int vwifi_get_station(struct wiphy *wiphy,
    sinfo->tx_failed = vif->stats.tx_dropped;
    sinfo->tx_bytes = vif->stats.tx_bytes;
    sinfo->rx_bytes = vif->stats.rx_bytes;
+
+


Nit: stray line

EricccTaiwan · 2025-06-13T19:17:02Z

vwifi.c

-            sinfo->tx_bytes, sinfo->rx_bytes);
-
-    /* Dynamic modulation based on signal strength */
+    /* Checks vif->manual_mcs_set to use vif->manual_mcs if set;


~~s/Checks/Check~~
Edit: solved

EricccTaiwan · 2025-06-13T19:18:00Z

vwifi.c

@@ -2276,10 +2353,29 @@ static const struct ieee80211_rate vwifi_supported_rates[] = {
    RATE_ENT(120, 0x40),  RATE_ENT(180, 0x80),  RATE_ENT(240, 0x100),
    RATE_ENT(360, 0x200), RATE_ENT(480, 0x400), RATE_ENT(540, 0x800),
 };
-


I don't think this is necessary.

dingsen-Greenhorn · 2025-06-20T17:52:44Z

$ sudo ip netns exec ns1 iw dev vw1 link 
Connected to 00:76:77:30:00:00 (on vw1)
        SSID: test
        freq: 2437.0
        RX: 282 bytes (2 packets)
        TX: 904 bytes (10 packets)
        signal: -72 dBm
        rx bitrate: 52.0 MBit/s MCS 25
        tx bitrate: 52.0 MBit/s MCS 25
$ sudo ip netns exec ns1 iw dev vw1 link 
Connected to 00:76:77:30:00:00 (on vw1)
        SSID: test
        freq: 2437.0
        RX: 282 bytes (2 packets)
        TX: 904 bytes (10 packets)
        signal: -85 dBm
        rx bitrate: 26.0 MBit/s MCS 24
        tx bitrate: 26.0 MBit/s MCS 24
$ sudo ip netns exec ns1 iw dev vw1 link 
Connected to 00:76:77:30:00:00 (on vw1)
        SSID: test
        freq: 2437.0
        RX: 282 bytes (2 packets)
        TX: 974 bytes (11 packets)
        signal: -53 dBm
        rx bitrate: 208.0 MBit/s MCS 29
        tx bitrate: 208.0 MBit/s MCS 29

above picture demonstrate the random signal strength mapping to different MCS .(code from MCS 24-31)

jychen0611 · 2025-06-21T07:46:14Z

Further discussion on this implementation can be found in issue82

dingsen-Greenhorn · 2025-06-21T11:10:31Z

This commit 0258f2afa2f21d5319b2dd5f0c287bf794950d34 has already been merged in PR #76. Please rebase your branch instead of committing it again.

solved thanks.

dingsen-Greenhorn · 2025-06-21T19:53:54Z

I test all of the possible index (MCS 0-31) (short GI /long GI),i will attach of my test log,and below is a part of the log

vwifi Bitrate Test Log - Sun Jun 22 03:25:36 CST 2025
Testing MCS 0-31 with long GI (0.8 µs) and short GI (0.4 µs) on vw1
----------------------------------------
Successfully initialized wpa_supplicant
Successfully initialized wpa_supplicant
Testing interface vw1 in ns1
Testing MCS 0 with lgi-2.4 on vw1
Set GI to long (0.8 µs)
Connected to 00:76:77:30:00:00 (on vw1)
	SSID: test
	freq: 2437.0
	RX: 282 bytes (2 packets)
	TX: 1714 bytes (19 packets)
	signal: -90 dBm
	rx bitrate: 6.5 MBit/s MCS 0
	tx bitrate: 6.5 MBit/s MCS 0
Success: MCS 0 lgi-2.4 bitrate 6.5 Mbps matches expected 6.5 Mbps
----------------------------------------
Testing MCS 0 with sgi-2.4 on vw1
Set GI to short (0.4 µs)
Connected to 00:76:77:30:00:00 (on vw1)
	SSID: test
	freq: 2437.0
	RX: 282 bytes (2 packets)
	TX: 1714 bytes (19 packets)
	signal: -98 dBm
	rx bitrate: 7.2 MBit/s MCS 0 short GI
	tx bitrate: 7.2 MBit/s MCS 0 short GI
Success: MCS 0 sgi-2.4 bitrate 7.2 Mbps matches expected 7.2 Mbps
----------------------------------------
Testing MCS 1 with lgi-2.4 on vw1
Set GI to long (0.8 µs)
Connected to 00:76:77:30:00:00 (on vw1)
	SSID: test
	freq: 2437.0
	RX: 282 bytes (2 packets)
	TX: 1714 bytes (19 packets)
	signal: -100 dBm
	rx bitrate: 13.0 MBit/s MCS 1
	tx bitrate: 13.0 MBit/s MCS 1
Success: MCS 1 lgi-2.4 bitrate 13.0 Mbps matches expected 13.0 Mbps
----------------------------------------
Testing MCS 1 with sgi-2.4 on vw1
Set GI to short (0.4 µs)
Connected to 00:76:77:30:00:00 (on vw1)
	SSID: test
	freq: 2437.0
	RX: 282 bytes (2 packets)
	TX: 1714 bytes (19 packets)
	signal: -97 dBm
	rx bitrate: 14.4 MBit/s MCS 1 short GI
	tx bitrate: 14.4 MBit/s MCS 1 short GI
Success: MCS 1 sgi-2.4 bitrate 14.4 Mbps matches expected 14.4 Mbps

and the script of testing bench can be sending mail to you, thanks a lot !
@jychen0611 @EricccTaiwan

contact me :[email protected]

jychen0611 · 2025-06-22T01:53:39Z

vwifi.c

+    VWIFI_TXRATE_GI_400NS, /* Short GI, 0.4 µs */
+};
+
+static int gi_mode = VWIFI_TXRATE_GI_800NS;


Avoid this approach. The GI should be updated in the set_bitrate_mask callback to support user configuration via the iw command.

jychen0611 · 2025-06-22T13:36:07Z

vwifi.c

@@ -88,6 +98,10 @@ struct vwifi_vif {
    struct wireless_dev wdev;
    struct net_device *ndev;
    struct net_device_stats stats;
+    int manual_mcs;


Remove unused variable.

jychen0611 · 2025-06-22T13:39:56Z

vwifi.c

+    int manual_mcs;
+    bool manual_mcs_set;
+    struct cfg80211_bitrate_mask bitrate_mask;
+    enum vwifi_txrate_gi gi; /* for GI tracking */


The GI information can be stored in the cfg80211_bitrate_mask structure, so there is no need to use an additional variable.

jychen0611 · 2025-06-22T13:42:11Z

vwifi.c

+    int mcs_index;
+    const char *modulation;
+    const char *coding_rate;
+


Add a comprehensive description of your dynamic MCS selection algorithm.

jychen0611 · 2025-06-22T14:01:43Z

vwifi.c

@@ -1446,9 +1603,13 @@ static int vwifi_dump_station(struct wiphy *wiphy,
 {
    struct vwifi_vif *ap_vif = ndev_get_vwifi_vif(dev);



Explain the modifications to the defensive sanity check in vwifi_dump_station in git commit message.

This commit enhances the vWIFI driver by implementing dynamic Modulation and Coding Scheme (MCS) selection in the `vwifi_get_station` function, adjusting the MCS index based on signal strength. After implement dynamic MCS can avoid TX power waste for a bad channel quality.

Implement the set_bitrate_mask callback in cfg80211_ops to support manual MCS settings using `iw dev <interface> set bitrates ht-mcs-2.4 <mcs_index>`, addressing reviewer feedback. Store the selected MCS in vwifi_vif->manual_mcs and track its state with vwifi_vif->manual_mcs_set. Support MCS indices 7, 15, 23, and 31, with validation and logging. Tested with `iw dev vw1 set bitrates ht-mcs-2.4 15`, achieving MCS 15 at 130.0 MBit/s (bitrate calculation pending refinement to ~52 MBit/s). Test commands format $sudo ip netns exec ns1 iw dev vw1 link $sudo ip netns exec ns1 iw dev vw1 set bitrates ht-mcs-2.4 15 /*(changable 7,15,23,31)*/ $sudo ip netns exec ns1 iw dev vw1 link

dingsen-Greenhorn · 2025-06-23T10:26:43Z

Below is the test of all possible index (MCS 0-31) (sgi,lgi),giving a part of it at below:

Successfully initialized wpa_supplicant
Successfully initialized wpa_supplicant
----------------------------------------
Testing MCS 0 with lgi-2.4 on vw1
Set GI to long (0.8 µs)
Connected to 00:76:77:30:00:00 (on vw1)
        SSID: test
        freq: 2437.0
        RX: 282 bytes (2 packets)
        TX: 764 bytes (8 packets)
        signal: -54 dBm
        rx bitrate: 6.5 MBit/s MCS 0
        tx bitrate: 6.5 MBit/s MCS 0
Success: MCS 0 lgi-2.4 bitrate 6.5 Mbps matches expected 6.5 Mbps
----------------------------------------
----------------------------------------
Testing MCS 1 with lgi-2.4 on vw1
Set GI to long (0.8 µs)
Connected to 00:76:77:30:00:00 (on vw1)
        SSID: test
        freq: 2437.0
        RX: 282 bytes (2 packets)
        TX: 764 bytes (8 packets)
        signal: -53 dBm
        rx bitrate: 13.0 MBit/s MCS 1
        tx bitrate: 13.0 MBit/s MCS 1
Success: MCS 1 lgi-2.4 bitrate 13.0 Mbps matches expected 13.0 Mbps
----------------------------------------
----------------------------------------
Testing MCS 0 with sgi-2.4 on vw1
Set GI to short (0.4 µs)
Connected to 00:76:77:30:00:00 (on vw1)
        SSID: test
        freq: 2437.0
        RX: 282 bytes (2 packets)
        TX: 974 bytes (11 packets)
        signal: -91 dBm
        rx bitrate: 7.2 MBit/s MCS 0 short GI
        tx bitrate: 7.2 MBit/s MCS 0 short GI
Success: MCS 0 sgi-2.4 bitrate 7.2 Mbps matches expected 7.2 Mbps
----------------------------------------
----------------------------------------
Testing MCS 1 with sgi-2.4 on vw1
Set GI to short (0.4 µs)
Connected to 00:76:77:30:00:00 (on vw1)
        SSID: test
        freq: 2437.0
        RX: 282 bytes (2 packets)
        TX: 974 bytes (11 packets)
        signal: -91 dBm
        rx bitrate: 14.4 MBit/s MCS 1 short GI
        tx bitrate: 14.4 MBit/s MCS 1 short GI
Success: MCS 1 sgi-2.4 bitrate 14.4 Mbps matches expected 14.4 Mbps
----------------------------------------

the test can be reproduce based on my providing test script <test_vwifi_bitrates.sh>.

EricccTaiwan · 2025-06-23T10:33:54Z

Please reformat the structure of the following commit 6af9412a2f2b855ce65147cbb42e23858dbaf7f8.
Commas must be attached to the preceding English word, followed by a space.

The auto MCS selection ,due to this function is based on only signal strength,
while the MCS should construct with modulation and coding scheme ,which the coding
scheme is related with BER (bite error rate),previous vWiFI only implement
random signal strength,meaning that bit error rate should also based on the channel state info.

dingsen-Greenhorn · 2025-06-23T10:41:35Z

Also, I realized a serious issue that in auto selection MCS, for the guard intervals (GI), which have multiple functions, such as prefix, that eliminate ICI and ISI in OFDM based system, now we only have signal strength, this should also consider many other physical parameters, such as delay spread for estimating the GI .The above issue also indicates that manual set guard intervals is a little bit weird in modern wireless system.
I can further open an issue to this, for details explanation, and my assessment of the solution.

jserv

Extend the existing scripts/verify.sh as an integrated test.

jserv

Use git rebase -i to rework git commits.

dingsen-Greenhorn · 2025-06-23T14:36:43Z

Extend the existing scripts/verify.sh as an integrated test.

Integrated and conduct result in same behavior of <test_vwifi_bitrates.sh>.

dingsen-Greenhorn · 2025-06-23T14:38:46Z

Use git rebase -i to rework git commits.

As we mention in meeting can i break this branch into multiple ?

Update the vwifi_set_bitrate_mask callback to support the full range of MCS indices 24 through 31, aligning with the 4-spatial-stream configuration in nf_band_2ghz. This change enabling support for manual MCS from 24-31 coding schemes (1/2, 3/4, 2/3, 5/6) and modulations (BPSK, QPSK,16-QAM, 64-QAM) as defined by the IEEE 802.11n specification. The callback now rejects indices outside 24–31, ensuring compliance with 4-stream capabilities and allowing comprehensive rate testing (26–260 Mbps). The auto MCS selection, due to this function is based on only signal strength, while the MCS should construct with modulation and coding scheme, which the coding scheme is related with BER (bite error rate), previous vWiFI only implement random signal strength, meaning that bit error rate should also based on the channel state info.

- Adjust MCS indices 24 to 31 to match spec table's modulation (BPSK to 64-QAM) and coding rates (1/2 to 5/6). - Revise signal strength thresholds (-45 to -75 dBm) to reflect realistic SNR requirements for each modulation scheme. - Preserve random signal generation logic using rand_int_smooth. - Ensure consistency with the reference table's structure and parameters.

…CS 0-31 This commit enhances the vwifi driver and test script to fully support HT mode with MCS 0-31, dynamic guard interval (GI) selection (0.8 µs and 0.4 µs), and robust testing. Key changes: - Adde `gi_mode` module parameter to vwifi.c to enable dynamic switching between long GI (0.8 µs) and short GI (0.4 µs), replacing hardcoded `vif->gi = VWIFI_TXRATE_GI_800NS` in `vwifi_set_bitrate_mask`. - Update `vwifi_set_bitrate_mask` to use `gi_mode` and added logging for GI and MCS settings. - Enhance `vwifi_get_station` to report GI correctly in `sinfo->txrate` and `sinfo->rxrate` with `RATE_INFO_FLAGS_SHORT_GI`. - Update `test_vwifi_bitrates.sh` to: - Test MCS 0-31 with both long and short GI on `vw1` and `vw2`. - Validate bitrates against `ht_mcs_table` (`rate_800ns`, `rate_400ns`). - Add error handling for `gi_mode` writes and connection checks. - Include debug output for `wpa_supplicant` and `iw dev link`. - Suggested debugfs fallback for per-interface GI control if `gi_mode` fails. These changes ensure compliance with reviewer requirements for HT mode, MCS 0-31, GI selection, and dynamic MCS selection, with robust testing and validation.

…egrate test script This commit refactors the vwifi driver to store Guard Interval (GI) information solely in cfg80211_bitrate_mask, eliminating the redundant short_gi variable, and introduces a spatial stream index for future optimization. It also adds a comprehensive comment block for manual_mcs and updates the test script to validate all MCS indices (0–31) with sgi-2.4 and lgi-2.4. changes: - vwifi_vif: - Remove short_gi, storing GI in vif->bitrate_mask.control[NL80211_BAND_2GHZ].gi. - Add spatial_streams field (int, default 1) for future multi-stream support. - Add manual_mcs field with detailed comment block explaining its role in storing the first enabled MCS for consistent bitrate reporting. - vwifi_set_bitrate_mask: - Store GI in vif->bitrate_mask.control[NL80211_BAND_2GHZ].gi, removing short_gi usage. - vwifi_get_station: - GI logic using vif->bitrate_mask.gi for short (0.4µs), long (0.8µs), or default GI. - Correct pr_info format string for modulation and coding_rate alignment. - Configure sinfo->rxrate/txrate with vif->bitrate_mask.gi and vif->manual_mcs. Test script (test_vwifi_bitrates.sh): -Updated to test MCS 0–31 with sgi-2.4 and lgi-2.4: - Test header (Testing MCS <mcs> with <gi> on vw1). - GI status (Set GI to long/short). - iw dev vw1 link output (MAC, SSID, freq, RX/TX, signal, bitrates). - Success/failure message with actual vs. expected bitrate. - Add expected bitrate arrays for lgi-2.4 and sgi-2.4. - Enhance stability with 2s retry sleep, 1s sleep after iw set bitrates, and 2s setup delay. - Ensure cleanup resets bitrate. - correct history typo. Testing: - Verified GI (0.4µs/0.8µs) and MCS (0–31) with iw dev vw1 set bitrates and iw dev vw1 link.

dingsen-Greenhorn · 2025-06-23T15:11:46Z

Please reformat the structure of the following commit 6af9412a2f2b855ce65147cbb42e23858dbaf7f8. Commas must be attached to the preceding English word, followed by a space.
The auto MCS selection ,due to this function is based on only signal strength,
while the MCS should construct with modulation and coding scheme ,which the coding
scheme is related with BER (bite error rate),previous vWiFI only implement
random signal strength,meaning that bit error rate should also based on the channel state info.

solved ! thanks.

jserv requested review from jychen0611 and rickywu0421 June 7, 2025 21:44

jserv requested changes Jun 7, 2025

View reviewed changes

jychen0611 suggested changes Jun 8, 2025

View reviewed changes

dingsen-Greenhorn force-pushed the dynamic_MCS branch from 79a5101 to 4e81b72 Compare June 8, 2025 15:33

jychen0611 suggested changes Jun 8, 2025

View reviewed changes

jychen0611 reviewed Jun 10, 2025

View reviewed changes

jychen0611 suggested changes Jun 12, 2025

View reviewed changes

dingsen-Greenhorn force-pushed the dynamic_MCS branch 13 times, most recently from c556347 to c96febb Compare June 13, 2025 19:24

dingsen-Greenhorn requested a review from jychen0611 June 18, 2025 11:59

jychen0611 mentioned this pull request Jun 19, 2025

Support manual bitrate mask control #81

Draft

EricccTaiwan reviewed Jun 20, 2025

View reviewed changes

dingsen-Greenhorn force-pushed the dynamic_MCS branch from 9ae6b0c to cd7ad7b Compare June 21, 2025 11:07

dingsen-Greenhorn force-pushed the dynamic_MCS branch 2 times, most recently from 0bd7dfb to 18db1a8 Compare June 21, 2025 19:42

jychen0611 suggested changes Jun 22, 2025

View reviewed changes

jychen0611 reviewed Jun 22, 2025

View reviewed changes

jychen0611 suggested changes Jun 22, 2025

View reviewed changes

dingsen-Greenhorn force-pushed the dynamic_MCS branch from d88d1b7 to 92f8f79 Compare June 23, 2025 10:10

dingsen-Greenhorn added 2 commits June 23, 2025 18:15

dingsen-Greenhorn force-pushed the dynamic_MCS branch from 92f8f79 to c142feb Compare June 23, 2025 10:16

jserv requested changes Jun 23, 2025

View reviewed changes

dingsen-Greenhorn force-pushed the dynamic_MCS branch from c142feb to fa402a1 Compare June 23, 2025 14:34

dingsen-Greenhorn force-pushed the dynamic_MCS branch from fa402a1 to 591910d Compare June 23, 2025 15:02

dingsen-Greenhorn requested a review from jserv June 23, 2025 15:04

dingsen-Greenhorn added 4 commits June 23, 2025 23:07

dingsen-Greenhorn force-pushed the dynamic_MCS branch from 591910d to c800205 Compare June 23, 2025 15:09

		/* Checks vif->manual_mcs_set to use vif->manual_mcs if set;
		* Assigns modulation string for manual MCS ; else auto change based

		@@ -1446,9 +1603,13 @@ static int vwifi_dump_station(struct wiphy *wiphy,
		{
		struct vwifi_vif *ap_vif = ndev_get_vwifi_vif(dev);

Implement dynamic MCS selection based on signal strength in vWIFI driver #80

Are you sure you want to change the base?

Implement dynamic MCS selection based on signal strength in vWIFI driver #80

Conversation

dingsen-Greenhorn commented Jun 7, 2025

Uh oh!

jserv left a comment

Choose a reason for hiding this comment

Uh oh!

jychen0611 left a comment

Choose a reason for hiding this comment

Uh oh!

dingsen-Greenhorn commented Jun 8, 2025

Uh oh!

jychen0611 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jychen0611 Jun 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jychen0611 Jun 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dingsen-Greenhorn commented Jun 8, 2025

Uh oh!

EricccTaiwan commented Jun 8, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dingsen-Greenhorn commented Jun 12, 2025

Uh oh!

jychen0611 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

EricccTaiwan Jun 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

EricccTaiwan Jun 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dingsen-Greenhorn commented Jun 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jychen0611 commented Jun 21, 2025

Uh oh!

dingsen-Greenhorn commented Jun 21, 2025

Uh oh!

dingsen-Greenhorn commented Jun 21, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dingsen-Greenhorn commented Jun 23, 2025

Uh oh!

EricccTaiwan commented Jun 23, 2025

Uh oh!

dingsen-Greenhorn commented Jun 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

jychen0611 left a comment •

edited

Loading

jychen0611 Jun 8, 2025 •

edited

Loading

jychen0611 Jun 8, 2025 •

edited

Loading

EricccTaiwan Jun 8, 2025 •

edited

Loading

EricccTaiwan Jun 13, 2025 •

edited

Loading

dingsen-Greenhorn commented Jun 20, 2025 •

edited

Loading

dingsen-Greenhorn commented Jun 23, 2025 •

edited

Loading

dingsen-Greenhorn commented Jun 23, 2025 •

edited

Loading