Stablize variable typing and support integer truncation and sign extension #201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrXiao
reviewed
May 13, 2025
jserv
reviewed
May 13, 2025
jserv
reviewed
May 13, 2025
jserv
reviewed
May 13, 2025
|
Regards to the issue of sign extension on rv32 backend, should we introduce a compiler parameter |
It is a good idea. However, we then need to an effective way to select the extensions for RISC-V backend. |
jserv
reviewed
May 15, 2025
DrXiao
reviewed
May 17, 2025
DrXiao
reviewed
May 17, 2025
DrXiao
reviewed
May 17, 2025
DrXiao
reviewed
May 18, 2025
DrXiao
reviewed
May 19, 2025
In this patch, all variables (including IR generated variables) are now guaranteed to have default type "int" to later used for integer resizing, this includes truncation and sign extension. Currently, only following cases will generate resizing opcodes (OP_trunc & OP_sign_ext): - variable assignment to registers - function parameter preparation, variadic function parameters are default to have size of int type Additionally, several data structures and memory managements are adjusted to have extensibility, this includes local variable and syntactic block allocation. Close sysprog21#166.
|
I'll squash them as well to keep it tidy and simple. |
DrXiao
approved these changes
May 19, 2025
|
Thank @ChAoSUnItY for contributing! |
ChAoSUnItY
pushed a commit
to ChAoSUnItY/shecc
that referenced
this pull request
May 20, 2025
Stablize variable typing and support integer truncation and sign extension
ChAoSUnItY
pushed a commit
to ChAoSUnItY/shecc
that referenced
this pull request
May 21, 2025
Stablize variable typing and support integer truncation and sign extension
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a attempt to support variable typing for all local variables (including synthesized ones) so that integer truncation and sign extension could be implemented, which targets to fix #166.
Notice that there's still some works including type derivation from operators and code cleanup.
About sign extension in rv32
It seems that package
qemu-useris currently outdated (6.2.0) so Zbb extension is not supported, which results in the implementation of sign extension in rv32 currently using straightforward way to implement, that is bitwise shifting.Summary by Bito
This pull request enhances the variable typing system by implementing support for integer truncation and sign extension, optimizing memory allocation for local variables, and improving error handling. It addresses issue #166 and includes unit tests to ensure the reliability of these enhancements.Unit tests added: True
Estimated effort to review (1-5, lower is better): 2 - The changes are well-structured and documented, making the review process straightforward.