Remove misleading TRACE log comment #597
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
log_level is dynamic (attr->log_level)
jserv
reviewed
May 16, 2025
There was a problem hiding this comment.
Benchmarks
| Benchmark suite | Current: 2ab686a | Previous: a27625b | Ratio |
|---|---|---|---|
Dhrystone |
1322 Average DMIPS over 10 runs |
1285 Average DMIPS over 10 runs |
0.97 |
Coremark |
922.46 Average iterations/sec over 10 runs |
915.126 Average iterations/sec over 10 runs |
0.99 |
This comment was automatically generated by workflow using github-action-benchmark.
|
@vacantron, can you confirm the CI breakage of macOS-Arm64? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
log_level is dynamic (attr->log_level)
Summary by Bito
This pull request clarifies the logging functionality in the RISC-V implementation by removing a misleading comment. It updates the documentation to accurately reflect the dynamic nature of the log level based on the provided attribute, enhancing code clarity.Unit tests added: False
Estimated effort to review (1-5, lower is better): 2