Remove iconified pixmap check when drawing cursor #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cursor pixmap is always drawn if present. The check for whether it is iconified is unnecessary. Signed-off-by: Wei-Hsin Yeh <[email protected]>
|
Thank @weihsinyeh for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cursor pixmap is always drawn if present. The check for whether it is iconified is unnecessary.
Summary by Bito
This pull request enhances the cursor drawing logic by removing an unnecessary check for iconification, simplifying the code and ensuring the cursor is always drawn if present. The modification is focused on the src/screen.c file.