-
Notifications
You must be signed in to change notification settings - Fork 19
Add iconify and restore features on window frame #103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
To prevent twin_stack_blur() from blurring shadows over the window frame, twin_shadow_border() draws a black border beginning at the top Y position of the window's client area, offset by 'CONFIG_SHADOW_BLUR / 2 + 1'. Signed-off-by: Wei-Hsin Yeh <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refine the subject and descriptions.
The "maximize" and "minimize" icons are somewhat unclear. In the proposed changes for Mado, they appear to function as toggle options for shadowing and unshadowing rather than traditional window maximizing and minimizing. |
In this commit, clicking the minimize button causes the window to display only its title bar. |
Can you clarify the descriptions of this pull request accordingly? |
Originally, I want to put button on these icons. However, the button's layout mechanism restricts it to being displayed only within the area of the window's client region. Specifically, As for where the layout of the widget begins within |
The subject '"dd iconify and maximize features on window frame" is misleading. It is indeed a window operation for iconifying and adjusting back to the original setting, meaning that there is no real "maximize" operation applied to any window. |
Add a condition in twin_window_dispatch() to handle clicks on the iconify and restore buttons located on the window frame. The positions of these buttons are calculated for click detection. A iconified window is inactive, even if it remains at the top of the screen. A window is considered active when it is the topmost window and is not iconified. When the window is active, its title bar turns blue. Signed-off-by: Wei-Hsin Yeh <[email protected]>
Thank @weihsinyeh for contributing! |
This pull request introduces iconify and restore functionality for windows.
It also updates the logic for determining when a window is considered active.
The window frame now changes to blue only when the window is not iconified and is the topmost window.
Summary by Bito
This pull request enhances the window management system by introducing minimize and maximize functionality, along with an iconify property in the window structure. It updates the drawing logic to reflect the active state of windows based on their minimized status, changing the window frame color accordingly.