V3.0 4826 4817 #4827
Open
V3.0 4826 4817 #4827
+1,966
−458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Port commit a8310f4
Accept a reference to a vector instead of returning a deque
MySQL_Logger::insertMysqlEventsIntoDb() populate table `stats_mysql_query_events` using mysql query events in the circular buffer
MySQL_Logger::processEvents() is responsible for dumping mysql query events
from the circular buffer into SQLite tables.
DUMP EVENTSLOG commands trigger a call to processEvents():
* DUMP EVENTSLOG FROM BUFFER TO MEMORY: copies events to the in-memory SQLite table
* DUMP EVENTSLOG FROM BUFFER TO DISK: copies events to the on-disk SQLite table
* DUMP EVENTSLOG FROM BUFFER TO BOTH: copies events to both in-memory and on-disk
SQLite tables simultaneously
Port of commit 23e3244
Added new Admin variable stats_mysql_eventslog_sync_buffer_to_disk . This variable defines how frequently mysql query eventslog are automatically dumped to disk.
In MySQL_Event copy constructor, queries are copied up to eventslog_buffer_max_query_length bytes.
Added enhancements: * added mysql-eventslog_table_memory_size * liste columns names in insertMysqlEventsIntoDb() * added counters and metrics (not exported yet) Port of commit 8f0324b
Added function MySQL_Logger::getAllMetrics() to export all metrics related to eventlogs
Port of commit 9eeed3c
Port of commit 234d4e6
Adding logging for errors generated directly directly by ProxySQL
New `errno` column in tables: - stats_mysql_query_events - history_mysql_query_events Logging into `stats_mysql_errors` also errors generated by ProxySQL (no backend) Added initial TAP test to be extended
SQLite amalgamation doesn't support DELETE with ORDER BY . Thus the DELETE with ORDER BY was replaced by a SELECT to retrieve the maximum id, followed by a DELETE up to that id.
After the migration of mysql_sessions from PtrArray to vector , call to end_thread() must be controlled in a different way
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge of PRs #4826 and #4817