Be tolerant when encountering emissiveFactor with array length 4 #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyalldawson
added a commit
to nyalldawson/QGIS
that referenced
this pull request
Aug 24, 2023
of 4 instead of aborting the model loading Submitted upstream as syoyo/tinygltf#445
wonder-sk
pushed a commit
to qgis/QGIS
that referenced
this pull request
Aug 24, 2023
of 4 instead of aborting the model loading Submitted upstream as syoyo/tinygltf#445
|
The spec says emissiveFactor is https://registry.khronos.org/glTF/specs/2.0/glTF-2.0.html#reference-material What is gltf-validator's result to emissiveFactor with |
|
How about if I add an optional "flags" argument to model loading, with a "permissive" flag which enables workarounds like this? |
|
Adding a flag to control the parsing behavior would be a nice idea. For example...
|
of 4 instead of aborting the model loading
nyalldawson
force-pushed
the
permissive
branch
from
5407c62
to
8c85d5e
Compare
|
@syoyo how's that now? |
Thanks! Let me give some time to review it. |
|
Merged! |
This was referenced Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raise a warning when encountering emissiveFactor with array length of 4 and truncate to the first 3 elements, instead of aborting the model loading entirely.