Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Super cache mang #1754

Merged
merged 8 commits into from
Jul 18, 2024
Merged

Super cache mang #1754

merged 8 commits into from
Jul 18, 2024

Conversation

stolinski
Copy link
Collaborator

@stolinski stolinski commented Jul 18, 2024

Completely re-works the redis caching system. Types are now insanely solid, api is much more simple to use, say goodbye to obscure errors in sentry related to caching. This just replaces the existing cached queries and rewrites they cache_mang (now super_cache_mang).
Completes #1753 #1550 and the many many permeations of #1756

Copy link

vercel bot commented Jul 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
syntax-website ✅ Ready (Inspect) Visit Preview Jul 18, 2024 8:02pm

@stolinski
Copy link
Collaborator Author

Also fixes #1550

@stolinski
Copy link
Collaborator Author

stolinski commented Jul 18, 2024

Here are the new cache methods.
Accessed via await cache.shows.list_shows();

export const cache = {
	shows: {
		show,
		latest_shows,
		list_shows,
		count_shows,
		drop_show_cache,
		drop_shows_list_cache
	}
};

@stolinski stolinski requested review from wesbos and w3cj July 18, 2024 17:31
@stolinski stolinski marked this pull request as ready for review July 18, 2024 17:31
Copy link

codecov bot commented Jul 18, 2024

Bundle Report

Changes will increase total bundle size by 1.48kB ⬆️

Bundle name Size Change
website-client-esm 2.26MB 0 bytes
website-server-esm 30.68MB 1.48kB ⬆️

@w3cj
Copy link
Contributor

w3cj commented Jul 18, 2024

Trying it out now. Added a PR to run redis locally: #1757

@w3cj
Copy link
Contributor

w3cj commented Jul 18, 2024

Added a PR to simplify date conversion when pulling from the cache: #1759

@stolinski stolinski merged commit 4b7faac into main Jul 18, 2024
3 of 4 checks passed
@stolinski stolinski deleted the super-cache-mang branch July 18, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants