#1195: Stop the player and reset player state when close is called #1425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@themisterholliday is attempting to deploy a commit to the Syntax Team on Vercel. A member of the Team first needs to authorize it. |
|
This should also fix: #1338 |
|
@stolinski You're handling this in your recent player work right? |
|
Yep! Apart of reworking minimize, close features will be ready this week. |
|
But I'll merge your changes into my branch. Instead of main. |
|
Cool cool. |
stolinski
added a commit
that referenced
this pull request
Dec 15, 2023
* adds header icons * Add hotkeys to the audio player (#1203) * Add @svelte-put/shortcut as a dependency * Implement player hotkeys * Pause and reset show on player close * Implement minimized player * Move hotkeys into +layout and refactor into object * Remove unused test file * Implement hotkey modal * Add vitest tests for formatShortcut util * Rebuild lockfile after rebase * Update modal styling * Reset core-js version --------- Co-authored-by: Scott Tolinski <[email protected]> * moves status into it's own writable * Stop the player and reset player state when close is called (#1425) Co-authored-by: Scott Tolinski <[email protected]> * adds more complex player status to player state for more control * reworks hotkeys to fix play pause issues * major work on hotkeys and adds share window * modifies redirects hook to keep query params on redirect * adds completes timestamp at time links * slight tweak to hotkeys * ficxes icon issue caused by merge --------- Co-authored-by: Ratul Maharaj <[email protected]> Co-authored-by: Craig Holliday <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Only stop the player and reset the player state when close is called.
This would interfere a tiny bit with #1203
The fix for that should only be in the state object, so whichever is merged first, we can fix the other.
Related to #1195
Some other ideas
It could be good to save settings like timestamp for previously played podcasts and playback speed selection
Added a video but had to reduce the quality because of GH's limits
sfm_player_close.mov