Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates all deps and removes illegal $inspect call #41

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

stolinski
Copy link
Contributor

Updates everything at once. Mostly minor versions.
Moves svelte to "next" so that we don't get behind on v5 versions for now. Same with vite-plugin-svelte which should be version 4.x

Also updates cargo lock for tauri deps. Tested on my end and things are working perfectly.

@stolinski
Copy link
Contributor Author

Closes #40

@w3cj
Copy link
Member

w3cj commented Sep 26, 2024

  • MP3 conversion progress is no longer reported
    • It immediately shows the file path, but the CLI still shows progress
  • Get error in console: Unhandled Promise Rejection: webview.internal_toggle_devtools not allowed. Permissions associated with this command: webview:allow-internal-toggle-devtools, webview:default
    • Likely need to add permission to tauri json file

@stolinski
Copy link
Contributor Author

  • Not seeing the webview errors
Screenshot 2024-09-26 at 1 25 18 PM

I think this might be a version thing. Maybe running cargo update from your src-tauri dir will fix for you.

@stolinski stolinski requested a review from w3cj September 26, 2024 20:26
@w3cj
Copy link
Member

w3cj commented Sep 26, 2024

Looks good, but now if the mp3 file already exists, it doesn't do anything at all... progress bar shows, but no progress updates in terminal.

@stolinski
Copy link
Contributor Author

That should be how it functioned before pre-update? I don't think anything I modified should have effected that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants