Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Unit test for RemoteStartTransaction nested dataclass #5

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ajmirsky
Copy link

@ajmirsky ajmirsky commented Dec 9, 2024

Changes included in this PR

adding a unit test to verify that serializing and deserializing works if you declare an attribute as a dict or a nested dataclass

New behavior

no change

Impact

none. unit test included is to prevent breaking changes

ajmirsky and others added 4 commits December 18, 2024 08:22
PR mobilityhouse#172 updated with master. 

Smart charging algos conception and validation has become a requirement
for charging infrastructure. Every single code lines that can help at
implementing and testing it worse the effort.

closes mobilityhouse#172 

Associated unit tests PR: mobilityhouse#690

---------

Signed-off-by: Jérôme Benoit <[email protected]>
Co-authored-by: Adrian Gruetter <[email protected]>
Co-authored-by: grutts <[email protected]>
Co-authored-by: Patrick Roelke <[email protected]>
…lityhouse#694)

### Changes included in this PR 

***Breaking change***
As per the warning in 1.0.0 this PR removes deprecated Action items from
the `enums.py` files to coincide with the 2.0.0 release, updates code
references and updates documentation to be consistent with the change
including string references.

For example:
- replaces deprecated Action enums such as `Action.BootNotification`
with `Action.boot_notification`
- replaces string references such as `@on("BootNotification")` and
`action="BootNotification"` with `Action.boot_notification`

If users of the library have not already migrated to the new Action
enums they will need to do so before using 2.0.0.

### Checklist

1. [x] Does your submission pass the existing tests?
2. [x] Are there new tests that cover these additions/changes? 
3. [x] Have you linted your code locally before submission?
… if you declare an attribute as a dict or a nested dataclass
@jainmohit2001 jainmohit2001 force-pushed the unit_test_for_charging_profiles branch from 0a34b9d to e7617b1 Compare December 19, 2024 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants