Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): android hardware back press for bottom-sheets #2419

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

pwltr
Copy link
Collaborator

@pwltr pwltr commented Jan 3, 2025

Description

  • Add a new hook useBottomSheetScreenBackPress to properly handle hardware back button on Android when bottom-sheets are open.
  • Add missing back button handling for standalone bottom-sheets
  • Fix back button handling for navigators nested in bottom-sheets
  • Add closeAllSheets action

Linked Issues/Tasks

Closes #2371

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (improving code without creating new functionality)

Tests

  • Detox test
  • Unit test
  • No test

QA Notes

Make sure back button behaves as expected when bottom-sheets are open. This is Android only.

@pwltr pwltr requested a review from coreyphillips January 3, 2025 12:42
@pwltr pwltr merged commit abbf6e6 into master Jan 7, 2025
7 checks passed
@pwltr pwltr deleted the fix/android-backpress branch January 7, 2025 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Back button navigating after scanning QR closes Bitkit instead of closing bottom sheet
2 participants