-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FLUT-926192 - [Feature] Modified assist view name and updated API links #1050
FLUT-926192 - [Feature] Modified assist view name and updated API links #1050
Conversation
Build Status: INPROGRESS 🔃 |
CI Status: SUCCESS ✅ |
Build Status: INPROGRESS 🔃 |
CI Status: SUCCESS ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this file name is case sensitive?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ai-assistview-theme.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Folder name also be small letter - check other widgets
ai-assistview = folder name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @VijayakumarMariappan sir,
I have modified the folder name AIAssistView to ai-assistview and renamed the file names AIAssistView-theme.md file to ai-assistview-theme.md, as per your suggestions. checked and ensured in all places of UG docs.
Regards,
Thankyou
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ai-assistview
Name always as this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @VijayakumarMariappan Sir,
I have completed modifying the images folder name assistview-overview.gif to ai-assistview-overview.gif as per your suggestions.
Regards,
Thankyou
<ul> | ||
<li><a href="/Flutter/assistview/overview">Overview</a></li> | ||
<li><a href="/Flutter/assistview/getting-started">Getting Started</a></li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In link - correct the widget name with casing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @VijayakumarMariappan sir,
I have modified the folder name AIAssistView to ai-assistview in the toc file, checked and ensured in all places of UG docs.
Regards,
Thankyou
@@ -238,7 +238,7 @@ The message author's avatar displays either an image or the initials of their na | |||
data: response, | |||
time: DateTime.now(), | |||
author: const AssistMessageAuthor( | |||
id: '123-002', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AI AssistView ID - Just mention 'ID'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @VijayakumarMariappan Sir,
I have modified the AI AssistView ID to ID in the source conversation area page of UG docs as per your suggestions.
Regards,
Thankyou
Build Status: INPROGRESS 🔃 |
CI Status: SUCCESS ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine
Feature description
Analysis and design
If there is an external design, link to its project documentation area.
If there is an internal discussion on the forum, provide the link.
Solution description
Describe your code changes in detail for reviewers.
Output screenshots
Post the output screenshots if an UI is affected or added due to this feature.
Areas affected and ensured
List the areas are affected by your code changes.
API Changes
List all API changes here (or just put None), example:
Added:
Changed:
Behavioral Changes
Describe any non-bug related behavioral changes that may change how users app behaves when upgrading to this version of the codebase.
Test cases
Provide the unit testing written file details to understand the use cases considered in this implementation.
If there is no TDD (if it’s not possible to follow), provide the UI automation script location and the Excel file that contains the use cases considered in this implementation.
Provide the test cases Excel file alone if the feature cannot be automated in any case.
List out all the scenarios you have tested after include these changes. You can refer the predefined scenarios from below link.
https://syncfusion.atlassian.net/wiki/display/CHARTXAMARIN/Chart+Test+Plan
Testbed sample location
Provide the test bed sample location where code reviewers can review the new feature’s behaviors. This depends on the CI process that your team follows. It can be from NPMCI, HockeyApp, staging site, local server, etc.
Does it have any known issues?
If this feature contains any known issues, provide the proper details about the issues.
Does it have memory leak?
Ensure the feature contains memory leak or not (if applicable).
MR CheckList