Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FLUT-926192 - [Feature] Modified assist view name and updated API links #1050

Conversation

Hariram-SF4428
Copy link
Contributor

Feature description

  • Task ID: [FLUT-926192], [FLUT-926190]
  • Modified widget name in all pages, places and modified the GIF with width factor 0.95.
  • Updated API link to all SfAIAssistView widget direct and class APIs, also added FT and SB link.

Analysis and design

If there is an external design, link to its project documentation area.
If there is an internal discussion on the forum, provide the link.

Solution description

Describe your code changes in detail for reviewers.

Output screenshots

Post the output screenshots if an UI is affected or added due to this feature.

Areas affected and ensured

List the areas are affected by your code changes.

API Changes

List all API changes here (or just put None), example:

Added:

  • string ListView.GroupName { get; set; } //Bindable Property
  • int ListView.GroupId { get; set; } // Bindable Property
  • void ListView.Clear ();

Changed:

  • object ListView.SelectedItem => Cell ListView.SelectedItem

Behavioral Changes

Describe any non-bug related behavioral changes that may change how users app behaves when upgrading to this version of the codebase.

Test cases

Provide the unit testing written file details to understand the use cases considered in this implementation.
If there is no TDD (if it’s not possible to follow), provide the UI automation script location and the Excel file that contains the use cases considered in this implementation.
Provide the test cases Excel file alone if the feature cannot be automated in any case.

List out all the scenarios you have tested after include these changes. You can refer the predefined scenarios from below link.

https://syncfusion.atlassian.net/wiki/display/CHARTXAMARIN/Chart+Test+Plan

Testbed sample location

Provide the test bed sample location where code reviewers can review the new feature’s behaviors. This depends on the CI process that your team follows. It can be from NPMCI, HockeyApp, staging site, local server, etc.

Does it have any known issues?

If this feature contains any known issues, provide the proper details about the issues.

Does it have memory leak?

Ensure the feature contains memory leak or not (if applicable).

MR CheckList

  • Does it follow the design guidelines? It is mandatory that, we should not move the changes without reading this.
  • Did UI automation passed without errors? If it is customer issue, make sure it is included in the IR automation.
  • Properly working in Xamarin.Forms previewer.
  • Ensured in iOS, Android, UWP and macOS (if supported).
  • Have you added API comments if it is new API?
  • Does it need localization? If so, update resx file in GitHub.
  • Whether we have added new APIs? If so, whether it is as per the guidelines?
  • If changes are made in the Xamarin.Forms sample browser project file, whether it is included in the props file too? If not, your sample level changes will not reflect in the application published in the hockey app.
  • Have you ensured the changes in Android API 19 and iOS 9?

@Syncfusion-CI
Copy link

Build Status: INPROGRESS 🔃
Build Location: FLUT-926192-UG-docs-assist-view-name-and-API-link-changes

@Syncfusion-CI
Copy link

CI Status: SUCCESS ✅
Source Compilation: SUCCESS ✅
Build Location: FLUT-926192-UG-docs-assist-view-name-and-API-link-changes
Technical Error(s): 0
Spelling Error(s): 0
Image Alt Text Error(s): 0
Image Size Error(s): 0
Image Name Error(s): 0
FT Layout Syntax Error(s): 0
Front matter Error(s): 0
File Path Error(s): 0
CodeSnippet File Path Missing Error(s): 0
Toc Anchor Tags Validation Error(s): 0
MD Tag Validation Error(s): 0

@SyncfusionBuild
Copy link
Contributor

Build Status: INPROGRESS 🔃
Build Location: FLUT-926192-UG-docs-assist-view-name-and-API-link-changes

@SyncfusionBuild
Copy link
Contributor

CI Status: SUCCESS ✅
Source Compilation: SUCCESS ✅
Build Location: FLUT-926192-UG-docs-assist-view-name-and-API-link-changes
Technical Error(s): 0
Spelling Error(s): 0
Image Alt Text Error(s): 0
Image Size Error(s): 0
Image Name Error(s): 0
FT Layout Syntax Error(s): 0
Front matter Error(s): 0
File Path Error(s): 0
CodeSnippet File Path Missing Error(s): 0
Toc Anchor Tags Validation Error(s): 0
MD Tag Validation Error(s): 0

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this file name is case sensitive?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ai-assistview-theme.md

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Folder name also be small letter - check other widgets

ai-assistview = folder name

Copy link
Contributor Author

@Hariram-SF4428 Hariram-SF4428 Dec 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @VijayakumarMariappan sir,

I have modified the folder name AIAssistView to ai-assistview and renamed the file names AIAssistView-theme.md file to ai-assistview-theme.md, as per your suggestions. checked and ensured in all places of UG docs.

Regards,
Thankyou

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ai-assistview

Name always as this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @VijayakumarMariappan Sir,

I have completed modifying the images folder name assistview-overview.gif to ai-assistview-overview.gif as per your suggestions.

Regards,
Thankyou

<ul>
<li><a href="/Flutter/assistview/overview">Overview</a></li>
<li><a href="/Flutter/assistview/getting-started">Getting Started</a></li>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In link - correct the widget name with casing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @VijayakumarMariappan sir,

I have modified the folder name AIAssistView to ai-assistview in the toc file, checked and ensured in all places of UG docs.

Regards,
Thankyou

@@ -238,7 +238,7 @@ The message author's avatar displays either an image or the initials of their na
data: response,
time: DateTime.now(),
author: const AssistMessageAuthor(
id: '123-002',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI AssistView ID - Just mention 'ID'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @VijayakumarMariappan Sir,

I have modified the AI AssistView ID to ID in the source conversation area page of UG docs as per your suggestions.

Regards,
Thankyou

@Syncfusion-CI
Copy link

Build Status: INPROGRESS 🔃
Build Location: FLUT-926192-UG-docs-assist-view-name-and-API-link-changes

@SyncfusionBuild
Copy link
Contributor

CI Status: SUCCESS ✅
Source Compilation: SUCCESS ✅
Build Location: FLUT-926192-UG-docs-assist-view-name-and-API-link-changes
Technical Error(s): 0
Spelling Error(s): 0
Image Alt Text Error(s): 0
Image Size Error(s): 0
Image Name Error(s): 0
FT Layout Syntax Error(s): 0
Front matter Error(s): 0
File Path Error(s): 0
CodeSnippet File Path Missing Error(s): 0
Toc Anchor Tags Validation Error(s): 0
MD Tag Validation Error(s): 0

Copy link
Collaborator

@VijayakumarMariappan VijayakumarMariappan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine

@VijayakumarMariappan VijayakumarMariappan merged commit b48ce38 into hotfix/hotfix-v28.1.33 Dec 16, 2024
1 check passed
@VijayakumarMariappan VijayakumarMariappan deleted the FLUT-926192-UG-docs-assist-view-name-and-API-link-changes branch December 16, 2024 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants