-
Notifications
You must be signed in to change notification settings - Fork 80
1007599: Add a Accessibility file in Sankey controls. #7535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
Conversation
|
Build Status: INPROGRESS 🔃 |
|
CI Status: SUCCESS ✅ |
|
Build Status: INPROGRESS 🔃 |
|
CI Status: SUCCESS ✅ |
Sittiq3586
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requested Changes.
blazor/sankey/accessibility.md
Outdated
|
|
||
| Element |Default description | ||
| -----|----- | ||
| Datalabel |Reads the Point value. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We didn't use DataLabel for Sankey instead we use like "Labels" using SankeyLabelSettings. Check that and change the content properly.
| -----|----- | ||
| Datalabel |Reads the Point value. | ||
| Node |Reads the Node value. | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also check the accessibility for links and legends for Sankey and add them if capable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Modified the content.
| | <kbd>←</kbd> | <kbd>←</kbd> | Moves focus to the data point to the left of the selected node. | | ||
| | <kbd>→</kbd> | <kbd>→</kbd> | Moves focus to the data point to the right of the selected node. | | ||
| | <kbd>Ctrl</kbd> + <kbd>P</kbd> | <kbd>⌘</kbd> + <kbd>P</kbd> | Prints the Sankey. | | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Ensuring Accessibility" content was missing. Check with Chart component UG and update that content too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add the missing content in Accessibility files
|
Build Status: INPROGRESS 🔃 |
|
The running CI Job is terminated due to changes committed on the source branch for this Merge Request and CI triggered for latest commit. |
|
CI Status: ABORTED ❌ |
|
Build Status: INPROGRESS 🔃 |
|
CI Status: FAILURE ❌ |
…lazor-docs into 1007599-sankey-dm
|
Build Status: INPROGRESS 🔃 |
…lazor-docs into 1007599-sankey-dm
|
The running CI Job is terminated due to changes committed on the source branch for this Merge Request and CI triggered for latest commit. |
|
Build Status: INPROGRESS 🔃 |
|
CI Status: FAILURE ❌ |
|
Build Status: INPROGRESS 🔃 |
|
CI Status: FAILURE ❌ |
Add a Accessibility file in Sankey controls